Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: Source/modules/indexeddb/IDBOpenDBRequest.cpp

Issue 177633006: Implement IDBVersionChangeEvent ctor w/ IDBVersionChangeEventInit dict (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBOpenDBRequest.cpp
diff --git a/Source/modules/indexeddb/IDBOpenDBRequest.cpp b/Source/modules/indexeddb/IDBOpenDBRequest.cpp
index 9199f717a3d114ba0583a0c1f82f20c84defef3b..55327e810c0526f6dfc1c847bb6aeb0fdfebb817 100644
--- a/Source/modules/indexeddb/IDBOpenDBRequest.cpp
+++ b/Source/modules/indexeddb/IDBOpenDBRequest.cpp
@@ -69,8 +69,8 @@ void IDBOpenDBRequest::onBlocked(int64_t oldVersion)
IDB_TRACE("IDBOpenDBRequest::onBlocked()");
if (!shouldEnqueueEvent())
return;
- RefPtr<IDBAny> newVersionAny = (m_version == IDBDatabaseMetadata::DefaultIntVersion) ? IDBAny::createNull() : IDBAny::create(m_version);
- enqueueEvent(IDBVersionChangeEvent::create(IDBAny::create(oldVersion), newVersionAny.release(), EventTypeNames::blocked));
+ RefPtr<SerializedScriptValue> newVersionSSV = (m_version == IDBDatabaseMetadata::DefaultIntVersion) ? SerializedScriptValue::nullValue() : SerializedScriptValue::numberValue(m_version);
haraken 2014/02/25 01:14:38 Shall we add a test for nullValue as well?
+ enqueueEvent(IDBVersionChangeEvent::create(EventTypeNames::blocked, SerializedScriptValue::numberValue(oldVersion), newVersionSSV.release()));
}
void IDBOpenDBRequest::onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<WebIDBDatabase> backend, const IDBDatabaseMetadata& metadata, blink::WebIDBDataLoss dataLoss, String dataLossMessage)
@@ -102,7 +102,7 @@ void IDBOpenDBRequest::onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<WebIDBData
if (m_version == IDBDatabaseMetadata::NoIntVersion)
m_version = 1;
- enqueueEvent(IDBVersionChangeEvent::create(IDBAny::create(oldVersion), IDBAny::create(m_version), EventTypeNames::upgradeneeded, dataLoss, dataLossMessage));
+ enqueueEvent(IDBVersionChangeEvent::create(EventTypeNames::upgradeneeded, SerializedScriptValue::numberValue(oldVersion), SerializedScriptValue::numberValue(m_version), dataLoss, dataLossMessage));
}
void IDBOpenDBRequest::onSuccess(PassOwnPtr<WebIDBDatabase> backend, const IDBDatabaseMetadata& metadata)

Powered by Google App Engine
This is Rietveld 408576698