Implement IDBVersionChangeEvent ctor w/ IDBVersionChangeEventInit dict

Source/bindings/v8/SerializedScriptValue.cpp

Index: Source/bindings/v8/SerializedScriptValue.cpp
diff --git a/Source/bindings/v8/SerializedScriptValue.cpp b/Source/bindings/v8/SerializedScriptValue.cpp
index ffc9855c63085c8c082cac375aeb3541ef540d08..7bcf4438637d8985d0ad06c8c9daae004417f3bf 100644
--- a/Source/bindings/v8/SerializedScriptValue.cpp
+++ b/Source/bindings/v8/SerializedScriptValue.cpp
@@ -2296,13 +2296,18 @@ PassRefPtr<SerializedScriptValue> SerializedScriptValue::create()
 
 PassRefPtr<SerializedScriptValue> SerializedScriptValue::nullValue()
 {
-    return nullValue(v8::Isolate::GetCurrent());
+    v8::Isolate* isolate = 0;

[haraken, 2014/02/25 01:14:38]

I'm not really happy about this.

When we have an Isolate*, we want to assume that the Isolate* is non-NULL.
(We've eliminated almost all NULL Isolate* from the code base.)

If Writer starts using the maybe-NULL isolate in the future, it will cause
crashes since other code expects a non-NULL isolate.

Shall we pass an Isolate to nullValue() or keep v8::Isolate::GetCurrent()? I
agree that we should remove v8::Isolate::GetCurrent() but I think that
v8::Isolate::GetCurrent() is better than using 0.

[jsbell, 2014/02/25 17:42:10]

Okay. Since this is just packing bytes into a buffer using the writer, there's
no need for an isolate. It seemed like with tests for these cases (static
xxxValue() constructors) tests would catch any mistakes - it should have unit
tests at the very least, though. That would complicate further reworking of SSV,
though, so I understand if we want to avoid that.
 
The sites that construct a new IDBVersionChangeEvent do so without v8 on the
stack. In the current (IDBAny) approach, creating the new v8 value is deferred
until script accesses the property. In this patch, the SSV is used to defer the
creation instead.

I'll ponder.

+    Writer writer(isolate);
+    writer.writeNull();
+    String wireData = writer.takeWireString();
+    return adoptRef(new SerializedScriptValue(wireData));
 }
 
-PassRefPtr<SerializedScriptValue> SerializedScriptValue::nullValue(v8::Isolate* isolate)
+PassRefPtr<SerializedScriptValue> SerializedScriptValue::numberValue(double number)
 {
+    v8::Isolate* isolate = 0;

[haraken, 2014/02/25 01:14:38]

Ditto.

     Writer writer(isolate);
-    writer.writeNull();
+    writer.writeNumber(number);
     String wireData = writer.takeWireString();
     return adoptRef(new SerializedScriptValue(wireData));
 }