Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1776283002:
Let package_from_installed actually package the json files it now writes. (Closed)
|
Created:
4 years, 9 months ago by Nico Modified:
4 years, 9 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, brucedawson Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionLet package_from_installed actually package the json files it now writes.
I failed to do this in https://codereview.chromium.org/1706423002
BUG=495204
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299179
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
thakis@chromium.org changed reviewers: + scottmg@chromium.org
\noideanico
lgtm
\noideascott apparently
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776283002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776283002/1
Message was sent while issue was closed.
Description was changed from ========== Let package_from_installed actually package the json files it now writes. I failed to do this in https://codereview.chromium.org/1706423002 BUG=495204 ========== to ========== Let package_from_installed actually package the json files it now writes. I failed to do this in https://codereview.chromium.org/1706423002 BUG=495204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299179 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299179
Message was sent while issue was closed.
On 2016/03/09 17:59:59, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-infra-committers". > Note that this has nothing to do with OWNERS files. i'm OWNER but not committer here now? hrm
Message was sent while issue was closed.
On 2016/03/09 18:26:07, scottmg wrote: > On 2016/03/09 17:59:59, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started by full committers or once the patch has > > received an L-G-T-M from a full committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > Committers are members of the group "project-infra-committers". > > Note that this has nothing to do with OWNERS files. > > i'm OWNER but not committer here now? hrm Yeah, infra team decided to have a separate committer bit for infra repos, and discussed this plan on the infra list, where everyone was in favor ¯\_(ツ)_/¯ I added you to some thread and asked to add you to the list. Kind of weird they didn't look at owner files.
Message was sent while issue was closed.
On 2016/03/09 18:28:15, Nico (afk Mon-Tue Mar 14-15) wrote: > On 2016/03/09 18:26:07, scottmg wrote: > > On 2016/03/09 17:59:59, commit-bot: I haz the power wrote: > > > No L-G-T-M from a valid reviewer yet. > > > CQ run can only be started by full committers or once the patch has > > > received an L-G-T-M from a full committer. > > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > Committers are members of the group "project-infra-committers". > > > Note that this has nothing to do with OWNERS files. > > > > i'm OWNER but not committer here now? hrm > > Yeah, infra team decided to have a separate committer bit for infra repos, and > discussed this plan on the infra list, where everyone was in favor ¯\_(ツ)_/¯ I > added you to some thread and asked to add you to the list. Kind of weird they > didn't look at owner files. (^ talked to agable and he said you're now a committer. wasn't clear if he made you one 'cause i asked, or if he made you one earlier independent of my question, but in case you didn't know: you can now review win_toolchain/ changes again :-) ) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
