Let package_from_installed write the build env into json files in addition to SetEnv.cmd

Let package_from_installed write the build env into json files in addition to SetEnv.cmd

BUG=495204
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298862

[Nico, 2016-02-18 20:01:49]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2016-02-18 20:01:50]

OrderedDict 'cause I think having a dict after deserializing will make things
easier on the other side

[Nico, 2016-02-18 20:02:46]

forgot to cc bruce

[scottmg, 2016-02-18 20:11:43]

lgtm

https://codereview.chromium.org/1706423002/diff/1/win_toolchain/package_from_...
File win_toolchain/package_from_installed.py (right):

https://codereview.chromium.org/1706423002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:272: with open(set_env_prefix +
'.x86.json', 'w') as f:
Do we want 'wb' for these so that there's not \r's in files intended for
non-win?

[Nico, 2016-02-18 20:14:41]

thanks!

https://codereview.chromium.org/1706423002/diff/1/win_toolchain/package_from_...
File win_toolchain/package_from_installed.py (right):

https://codereview.chromium.org/1706423002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:272: with open(set_env_prefix +
'.x86.json', 'w') as f:
On 2016/02/18 20:11:43, scottmg wrote:
> Do we want 'wb' for these so that there's not \r's in files intended for
> non-win?

Sure, done. (In practice there are no newlines in json.dump output by default,
so it doesn't make a difference in practice)

[Nico, 2016-02-18 20:14:47]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-02-18 20:14:47]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1706423002/#ps20001
(title: "wb")

[commit-bot: I haz the power, 2016-02-18 20:14:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706423002/20001

[commit-bot: I haz the power, 2016-02-18 20:18:14]

Description was changed from

==========
Let package_from_installed write the build env into json files in addition to
SetEnv.cmd

BUG=495204
==========

to

==========
Let package_from_installed write the build env into json files in addition to
SetEnv.cmd

BUG=495204

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298862
==========

[commit-bot: I haz the power, 2016-02-18 20:18:15]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298862

[Nico, 2016-02-19 06:47:37]

(forgot to say: if either of you land a new package with these json files
included, please let me know. there's no rush and no need to do it just for this
if it's involved, but i'd like to know about it when it happens)