Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1776213002: Removed DefaultBrowser.SetDefaultAsyncDuration histogram (Closed)

Created:
4 years, 9 months ago by Patrick Monette
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed DefaultBrowser.SetDefaultAsyncDuration histogram This histogram is no longer used since the end of the AsyncSetAsDefault experiments. BUG=576490 Committed: https://crrev.com/c82a6be49d983a1bb5462833be6459ac0fea68d2 Cr-Commit-Position: refs/heads/master@{#380291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -56 lines) Patch
M chrome/browser/shell_integration.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/shell_integration.cc View 3 chunks +1 line, -46 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Patrick Monette
asvitkine@ Please review histograms.xml thakis@ Please review everything else. Thanks!
4 years, 9 months ago (2016-03-08 23:36:45 UTC) #2
Nico
lgtm there probably was some bug for the async default experiments? use that as BUG= ...
4 years, 9 months ago (2016-03-09 03:06:00 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 9 months ago (2016-03-09 19:13:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776213002/1
4 years, 9 months ago (2016-03-09 23:32:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 01:33:00 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 01:34:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c82a6be49d983a1bb5462833be6459ac0fea68d2
Cr-Commit-Position: refs/heads/master@{#380291}

Powered by Google App Engine
This is Rietveld 408576698