Chromium Code Reviews

Issue 1776133002: Add Android fonts to blimp engine (Closed)

Created:
4 years, 9 months ago by nyquist
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, David Trainor- moved to gerrit, maniscalco, klobag.chromium
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Android fonts to blimp engine The blimp engine is currently using Linux fonts, which works well for Linux clients. However, for Android clients, Skia should be instructed to use Android fonts instead to ensure that the font rendering works correctly. This CL adds a starting set of fonts to be used, ensures that they are part of the engine bundle, and provides documentation for how to use them in locally hosted engines and also for how to keep the fonts up to date. This also updates the engine manifest and starts loading a new dynamic library while running the engine plus fixes the documentation for running the engine as a container. Initial CL: https://codereview.chromium.org/1735783002/ Revert: https://codereview.chromium.org/1772343003/ BUG=585668, 588929 Committed: https://crrev.com/b4fd57023ade2863e463d3380456968dca6c8bcf Cr-Commit-Position: refs/heads/master@{#380022}

Patch Set 1 : Revert of revert #

Patch Set 2 : Moved fonts to tarball, updated documentation. #

Total comments: 6

Patch Set 3 : Removed references to chromeos #

Unified diffs Side-by-side diffs Stats (+974 lines, -12 lines)
M DEPS View 1 chunk +12 lines, -0 lines 0 comments
M blimp/README.md View 1 chunk +4 lines, -1 line 0 comments
M blimp/docs/container.md View 3 chunks +3 lines, -3 lines 0 comments
A blimp/docs/fonts.md View 1 chunk +35 lines, -0 lines 0 comments
M blimp/docs/running.md View 2 chunks +3 lines, -0 lines 0 comments
M blimp/engine/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments
M blimp/engine/DEPS View 1 chunk +1 line, -0 lines 0 comments
M blimp/engine/Dockerfile View 2 chunks +3 lines, -1 line 0 comments
M blimp/engine/engine-manifest.txt View 2 chunks +207 lines, -2 lines 0 comments
M blimp/engine/start_engine.sh View 1 chunk +2 lines, -1 line 0 comments
M blimp/tools/manifest-blacklist.txt View 1 chunk +1 line, -3 lines 0 comments
A third_party/blimp_fonts/.gitignore View 1 chunk +2 lines, -0 lines 0 comments
A third_party/blimp_fonts/BUILD.gn View 1 chunk +217 lines, -0 lines 0 comments
A third_party/blimp_fonts/LICENSE View 1 chunk +232 lines, -0 lines 0 comments
A third_party/blimp_fonts/LICENSE.Apache View 1 chunk +201 lines, -0 lines 0 comments
A + third_party/blimp_fonts/LICENSE.OFL View 0 chunks +-1 lines, --1 lines 0 comments
A + third_party/blimp_fonts/OWNERS View 1 chunk +1 line, -2 lines 0 comments
A third_party/blimp_fonts/README.chromium View 1 chunk +49 lines, -0 lines 0 comments
A third_party/blimp_fonts/font_bundle.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 21 (9 generated)
nyquist
dpranke: DEPS and GCS integration maniscalco: //blimp/README.md, //blimp/docs, //blimp/engine, //blimp/tools dtrainor: //third_party/blimp_fonts klobag: //third_party OWNERS
4 years, 9 months ago (2016-03-08 22:17:41 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 9 months ago (2016-03-08 22:26:16 UTC) #4
maniscalco
lgtm https://codereview.chromium.org/1776133002/diff/20001/blimp/docs/fonts.md File blimp/docs/fonts.md (right): https://codereview.chromium.org/1776133002/diff/20001/blimp/docs/fonts.md#newcode20 blimp/docs/fonts.md:20: upload_to_google_storage.py --archive -b chromium-fonts font_bundle Neat. Even simpler ...
4 years, 9 months ago (2016-03-08 22:33:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776133002/20001
4 years, 9 months ago (2016-03-08 22:33:31 UTC) #7
Dirk Pranke
lgtm w/ a couple of minor questions. https://codereview.chromium.org/1776133002/diff/20001/blimp/docs/container.md File blimp/docs/container.md (right): https://codereview.chromium.org/1776133002/diff/20001/blimp/docs/container.md#newcode46 blimp/docs/container.md:46: --build-dir out-chromeos/Debug ...
4 years, 9 months ago (2016-03-08 22:38:32 UTC) #8
nyquist
https://codereview.chromium.org/1776133002/diff/20001/blimp/docs/container.md File blimp/docs/container.md (right): https://codereview.chromium.org/1776133002/diff/20001/blimp/docs/container.md#newcode46 blimp/docs/container.md:46: --build-dir out-chromeos/Debug \ On 2016/03/08 22:38:32, Dirk Pranke wrote: ...
4 years, 9 months ago (2016-03-08 22:56:14 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776133002/40001
4 years, 9 months ago (2016-03-08 23:31:59 UTC) #11
klobag.chromium
lgtm
4 years, 9 months ago (2016-03-09 00:30:19 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 01:32:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776133002/40001
4 years, 9 months ago (2016-03-09 01:35:18 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 01:42:27 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:43:35 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b4fd57023ade2863e463d3380456968dca6c8bcf
Cr-Commit-Position: refs/heads/master@{#380022}

Powered by Google App Engine