Issue 177613005: Remove the TextTrackCue constructor

Issue 177613005: Remove the TextTrackCue constructor (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
tkent, haraken, acolwell GONE FROM CHROMIUM

CC:
blink-reviews, Nils Barth (inactive), nessy, arv+blink, jsbell+bindings_chromium.org, marja+watch_chromium.org, sof, gasubic, fs, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, kojih, watchdog-blink-watchlist_google.com, Nate Chapin, vcarbune.chromium, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove the TextTrackCue constructor Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/R34xpMQGtXU/XwXsi85Y7acJ BUG=346235 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167972

Patch Set 1 #

Patch Set 2 : restore Custom=ToV8 #

Patch Set 3 : fix fast/js/constructor-length.html #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -51 lines)			Patch
M	LayoutTests/fast/js/constructor-length.html	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/js/constructor-length-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/media/track/text-track-cue-constructor.html	View		1 chunk	+5 lines, -14 lines	0 comments	Download
M	LayoutTests/media/track/text-track-cue-constructor-expected.txt	View		1 chunk	+1 line, -3 lines	0 comments	Download
D	Source/bindings/v8/custom/V8TextTrackCueCustom.cpp	View	1	2 chunks	+0 lines, -27 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/track/TextTrackCue.idl	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Requesting IDL review from tkent, everything else from acolwell.

6 years, 10 months ago (2014-02-25 05:34:44 UTC) #1

philipj_slow

I forgot that CustomToV8 was needed for another reason, namely that APIs like TextTrack.getCueById return ...

6 years, 10 months ago (2014-02-25 16:32:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/177613005/40001

6 years, 10 months ago (2014-02-27 02:48:13 UTC) #8

Message was sent while issue was closed.

Change committed as 167972

Expand Messages | Collapse Messages