Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

Issue 177613005: Remove the TextTrackCue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix fast/js/constructor-length.html Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 14 matching lines...) Expand all
25 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 25 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
26 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 26 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
27 * OF THE POSSIBILITY OF SUCH DAMAGE. 27 * OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 #include "config.h" 30 #include "config.h"
31 #include "V8TextTrackCue.h" 31 #include "V8TextTrackCue.h"
32 32
33 #include "V8VTTCue.h" 33 #include "V8VTTCue.h"
34 34
35 #include "bindings/v8/ExceptionMessages.h"
36 #include "bindings/v8/ExceptionState.h"
37 #include "core/frame/UseCounter.h"
38
39 namespace WebCore { 35 namespace WebCore {
40 36
41 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo ntext, v8::Isolate* isolate) 37 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo ntext, v8::Isolate* isolate)
42 { 38 {
43 return toV8(toVTTCue(impl), creationContext, isolate); 39 return toV8(toVTTCue(impl), creationContext, isolate);
44 } 40 }
45 41
46 // Custom constructor to make new TextTrackCue(...) return a VTTCue. This is leg acy
47 // compat, not per spec, and should be removed at the earliest opportunity.
48 void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value> & info)
49 {
50 ExceptionState exceptionState(ExceptionState::ConstructionContext, "TextTrac kCue", info.Holder(), info.GetIsolate());
51 if (UNLIKELY(info.Length() < 3)) {
52 exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(3, i nfo.Length()));
53 exceptionState.throwIfNeeded();
54 return;
55 }
56 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( )));
57 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) );
58 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]);
59
60 Document& document = *toDocument(currentExecutionContext(info.GetIsolate())) ;
61 UseCounter::countDeprecation(document, UseCounter::TextTrackCueConstructor);
62
63 RefPtr<VTTCue> impl = VTTCue::create(document, startTime, endTime, text);
64 v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(), info.GetIso late());
65
66 v8SetReturnValue(info, wrapper);
67 }
68
69 } // namespace WebCore 42 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/media/track/text-track-cue-constructor-expected.txt ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698