Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: Source/core/xml/XPathStep.cpp

Issue 177613003: Consistently cache ElementData::length() before loops (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix test failure Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/PageSerializer.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathStep.cpp
diff --git a/Source/core/xml/XPathStep.cpp b/Source/core/xml/XPathStep.cpp
index 56d7d6907c9fbfd377e73f195c2fa5595f453f20..70f183e03f5158df43f45d0b323d8674f5b28f85 100644
--- a/Source/core/xml/XPathStep.cpp
+++ b/Source/core/xml/XPathStep.cpp
@@ -350,7 +350,8 @@ void Step::nodesInAxis(Node* context, NodeSet& nodes) const
if (!contextElement->hasAttributes())
return;
- for (unsigned i = 0; i < contextElement->attributeCount(); ++i) {
+ unsigned attributeCount = contextElement->attributeCount();
+ for (unsigned i = 0; i < attributeCount; ++i) {
RefPtr<Attr> attr = contextElement->ensureAttr(contextElement->attributeItem(i)->name());
if (nodeMatches(attr.get(), AttributeAxis, m_nodeTest))
nodes.append(attr.release());
« no previous file with comments | « Source/core/page/PageSerializer.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698