Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: Source/core/page/PageSerializer.cpp

Issue 177613003: Consistently cache ElementData::length() before loops (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix test failure Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/PageSerializer.cpp
diff --git a/Source/core/page/PageSerializer.cpp b/Source/core/page/PageSerializer.cpp
index 7f31c9c055639726f0477a0e03fa69a8af25ee07..e72a2af99ea944244db5d36f836a176ca23678b5 100644
--- a/Source/core/page/PageSerializer.cpp
+++ b/Source/core/page/PageSerializer.cpp
@@ -78,7 +78,8 @@ static bool isCharsetSpecifyingNode(const Node& node)
return false;
HTMLAttributeList attributes;
if (element.hasAttributes()) {
- for (unsigned i = 0; i < element.attributeCount(); ++i) {
+ unsigned attributeCount = element.attributeCount();
+ for (unsigned i = 0; i < attributeCount; ++i) {
const Attribute* attribute = element.attributeItem(i);
// FIXME: We should deal appropriately with the attribute if they have a namespace.
attributes.append(std::make_pair(attribute->name().localName(), attribute->value().string()));
« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698