Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 177603002: Revert 252408 "Adding talk_base::PacketOptions to P2P IPC Send m..." (Closed)

Created:
6 years, 10 months ago by bartfab (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 252408 "Adding talk_base::PacketOptions to P2P IPC Send m..." This made the ASAN bots fail: http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Release/builds/7563 > Adding talk_base::PacketOptions to P2P IPC Send message. > > Libjingle added a structure which will carry additional > meta information about the packet in Send API. This includes > DSCP code for the packet and packet authentication information. > This information must be used before the packet is sent over > the network. This requires options must be sent to the browser process. > > R=sergeyu@chromium.org > TBR=cevans@chromium.org,avi@chromium.org > > BUG= > > Review URL: https://codereview.chromium.org/170193002 TBR=mallinath@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -128 lines) Patch
M trunk/src/content/browser/renderer_host/p2p/socket_dispatcher_host.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_server.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 11 chunks +19 lines, -28 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp.h View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc View 4 chunks +9 lines, -17 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 7 chunks +16 lines, -25 lines 0 comments Download
M trunk/src/content/common/p2p_messages.h View 3 chunks +4 lines, -18 lines 0 comments Download
M trunk/src/content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/renderer/p2p_socket_client.h View 2 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/content/renderer/p2p/ipc_socket_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/content/renderer/p2p/socket_client_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/p2p/socket_client_impl.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bartfab (slow)
6 years, 10 months ago (2014-02-24 11:17:44 UTC) #1
bartfab (slow)
6 years, 10 months ago (2014-02-24 11:18:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r252900.

Powered by Google App Engine
This is Rietveld 408576698