Adding talk_base::PacketOptions to P2P IPC Send message.

Adding talk_base::PacketOptions to P2P IPC Send message.

Libjingle added a structure which will carry additional
meta information about the packet in Send API. This includes
DSCP code for the packet and packet authentication information.
This information must be used before the packet is sent over
the network. This requires options must be sent to the browser process.

R=sergeyu@chromium.org
TBR=cevans@chromium.org,avi@chromium.org

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252408

[Sergey Ulanov, 2014-02-19 02:36:38]

I don't understand what this CL is for. You are passing talk_base::PacketOptions
for each packet, but as far as I can tell only the dspc field from that struct
is actually used in the browser process. All other fields are SRTP-related and
I'm not sure how browser process could use them because SRTP is handled in the
renderer, not browser.

[Mallinath (Gone from Chromium), 2014-02-19 02:41:45]

On 2014/02/19 02:36:38, Sergey Ulanov wrote:
> I don't understand what this CL is for. You are passing
talk_base::PacketOptions
> for each packet, but as far as I can tell only the dspc field from that struct
> is actually used in the browser process. All other fields are SRTP-related and
> I'm not sure how browser process could use them because SRTP is handled in the
> renderer, not browser.

Good question, this is one of the CL in a series of CL's. The ultimate goal is
to do
packet authentication inside chrome browser process after updating extension.

There are other CL's inside libjingle which extracts keys from libsrtp and
pushes those to chrome.

This https://codereview.chromium.org/159353002/ has methods to manipulate RTP
header.

All this is done for doing bandwidth estimation better in webrtc by removing
unaccounted latency
like IPC and other queuing of packets before sending over the network.

[Mallinath (Gone from Chromium), 2014-02-20 18:48:22]

Ping

[Sergey Ulanov, 2014-02-20 19:29:21]

lgtm

[Mallinath (Gone from Chromium), 2014-02-20 19:51:45]

avi@ for content_common.gypi
cevans@ for content/common/p2p_messages.h and
content/public/renderer/p2p_socket_client.h

[Mallinath (Gone from Chromium), 2014-02-20 19:52:25]

The CQ bit was checked by mallinath@chromium.org

[commit-bot: I haz the power, 2014-02-20 19:54:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mallinath@chromium.org/170193002/200001

[Avi (use Gerrit), 2014-02-20 19:54:32]

content_common.gypi LGTM

[commit-bot: I haz the power, 2014-02-20 22:52:45]

Change committed as 252408