Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1775613005: Remove the CHECK when we fail to set the DXVA decoder output type. (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Remove the CHECK when we fail to set the DXVA decoder output type. Merging to M50 This CHECK fires intermittently and appears to be caused by buggy drivers and or AV malware combinations. In most of the crashes, I debugged, the failure was MF_E_INVALIDMEDIATYPE which indicates that the driver does not support H.264 decoding. In any case this code has now baked for a while on the field for DX11 and Win8+. So it should be ok to remove the CHECK BUG=588358 R=sandersd Review URL: https://codereview.chromium.org/1770223002 Cr-Commit-Position: refs/heads/master@{#379704} (cherry picked from commit 61b99f61f28341d2ba41e540498534c7769e9300) Committed: https://chromium.googlesource.com/chromium/src/+/fdf4152e255b6b62dc19032f8fb178020cf784e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ananta
Committed patchset #1 (id:1) manually as fdf4152e255b6b62dc19032f8fb178020cf784e6.
4 years, 9 months ago (2016-03-10 01:21:26 UTC) #2
sandersd (OOO until July 31)
4 years, 9 months ago (2016-03-10 01:24:28 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698