Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1770223002: Remove the CHECK when we fail to set the DXVA decoder output type. (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the CHECK when we fail to set the DXVA decoder output type. This CHECK fires intermittently and appears to be caused by buggy drivers and or AV malware combinations. In most of the crashes, I debugged, the failure was MF_E_INVALIDMEDIATYPE which indicates that the driver does not support H.264 decoding. In any case this code has now baked for a while on the field for DX11 and Win8+. So it should be ok to remove the CHECK BUG=588358 R=sandersd Committed: https://crrev.com/61b99f61f28341d2ba41e540498534c7769e9300 Cr-Commit-Position: refs/heads/master@{#379704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ananta
4 years, 9 months ago (2016-03-08 00:03:38 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 9 months ago (2016-03-08 00:26:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770223002/1
4 years, 9 months ago (2016-03-08 00:58:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34722)
4 years, 9 months ago (2016-03-08 01:44:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770223002/1
4 years, 9 months ago (2016-03-08 01:51:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 02:26:47 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 02:27:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61b99f61f28341d2ba41e540498534c7769e9300
Cr-Commit-Position: refs/heads/master@{#379704}

Powered by Google App Engine
This is Rietveld 408576698