Colors in views::StyledLabel.

ui/views/controls/link.cc

Index: ui/views/controls/link.cc
diff --git a/ui/views/controls/link.cc b/ui/views/controls/link.cc
index fcb73f10f1cbdd9066b94bfcb3b6b871d7efcb95..f6c298c6f1df1257d1291920e2e69101cda923d3 100644
--- a/ui/views/controls/link.cc
+++ b/ui/views/controls/link.cc
@@ -34,6 +34,14 @@ Link::Link(const string16& title) : Label(title) {
 Link::~Link() {
 }
 
+SkColor Link::GetDefaultEnabledColor() {
+#if defined(OS_WIN)
+  return color_utils::GetSysSkColor(COLOR_HOTLIGHT);

[Evan Stade, 2013/07/11 17:54:39]

I dont' know if this is an expensive operation, but previously it was optimized
to only be called once. Now it may be called more than once.

[fdoray, 2013/07/11 19:56:26]

It makes a call to a Windows function (GetSysColor). I now use a static variable
to make sure it's called only once, like before.

However, I'm not sure why a static variable was used.
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/link.cc?r1=271...
shows that a static variable was used even we no call to a Windows function was
made. The variable only stored the result of SkColorSetRGB(...).

On 2013/07/11 17:54:39, Evan Stade wrote:

+#else
+  return SkColorSetRGB(0, 51, 153);
+#endif
+}
+
 void Link::OnEnabledChanged() {
   RecalculateFont();
   View::OnEnabledChanged();
@@ -165,17 +173,15 @@ void Link::SetUnderline(bool underline) {
 
 void Link::Init() {
   static bool initialized = false;
-  static SkColor kDefaultEnabledColor;
+  static SkColor kDefaultEnabledColor = GetDefaultEnabledColor();
   static SkColor kDefaultDisabledColor;
   static SkColor kDefaultPressedColor;
   if (!initialized) {
 #if defined(OS_WIN)
-    kDefaultEnabledColor = color_utils::GetSysSkColor(COLOR_HOTLIGHT);
     kDefaultDisabledColor = color_utils::GetSysSkColor(COLOR_WINDOWTEXT);
     kDefaultPressedColor = SkColorSetRGB(200, 0, 0);
 #else
     // TODO(beng): source from theme provider.
-    kDefaultEnabledColor = SkColorSetRGB(0, 51, 153);
     kDefaultDisabledColor = SK_ColorBLACK;
     kDefaultPressedColor = SK_ColorRED;
 #endif