Colors in views::StyledLabel.

ui/views/controls/link.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/link.h"
 
 #include "build/build_config.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 16 matching lines @@
   Init();
 }
 
 Link::Link(const string16& title) : Label(title) {
   Init();
 }
 
 Link::~Link() {
 }
 
+SkColor Link::GetDefaultEnabledColor() {
+#if defined(OS_WIN)
+  return color_utils::GetSysSkColor(COLOR_HOTLIGHT);

[Evan Stade, 2013/07/11 17:54:39]

I dont' know if this is an expensive operation, but previously it was optimized
to only be called once. Now it may be called more than once.

[fdoray, 2013/07/11 19:56:26]

It makes a call to a Windows function (GetSysColor). I now use a static variable
to make sure it's called only once, like before.

However, I'm not sure why a static variable was used.
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/link.cc?r1=271...
shows that a static variable was used even we no call to a Windows function was
made. The variable only stored the result of SkColorSetRGB(...).

On 2013/07/11 17:54:39, Evan Stade wrote:

+#else
+  return SkColorSetRGB(0, 51, 153);
+#endif
+}
+
 void Link::OnEnabledChanged() {
   RecalculateFont();
   View::OnEnabledChanged();
 }
 
 const char* Link::GetClassName() const {
   return kViewClassName;
 }
 
 gfx::NativeCursor Link::GetCursor(const ui::MouseEvent& event) {
@@ skipping 111 matching lines @@
 
 void Link::SetUnderline(bool underline) {
   if (underline_ == underline)
     return;
   underline_ = underline;
   RecalculateFont();
 }
 
 void Link::Init() {
   static bool initialized = false;
-  static SkColor kDefaultEnabledColor;
+  static SkColor kDefaultEnabledColor = GetDefaultEnabledColor();
   static SkColor kDefaultDisabledColor;
   static SkColor kDefaultPressedColor;
   if (!initialized) {
 #if defined(OS_WIN)
-    kDefaultEnabledColor = color_utils::GetSysSkColor(COLOR_HOTLIGHT);
     kDefaultDisabledColor = color_utils::GetSysSkColor(COLOR_WINDOWTEXT);
     kDefaultPressedColor = SkColorSetRGB(200, 0, 0);
 #else
     // TODO(beng): source from theme provider.
-    kDefaultEnabledColor = SkColorSetRGB(0, 51, 153);
     kDefaultDisabledColor = SK_ColorBLACK;
     kDefaultPressedColor = SK_ColorRED;
 #endif
 
     initialized = true;
   }
 
   listener_ = NULL;
   pressed_ = false;
   underline_ = true;
@@ skipping 17 matching lines @@
 void Link::RecalculateFont() {
   // Underline the link iff it is enabled and |underline_| is true.
   const int style = font().GetStyle();
   const int intended_style = (enabled() && underline_) ?
       (style | gfx::Font::UNDERLINE) : (style & ~gfx::Font::UNDERLINE);
   if (style != intended_style)
     Label::SetFont(font().DeriveFont(0, intended_style));
 }
 
 }  // namespace views