Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1775583002: Moves FrameDecorations from Display to WindowManagerState (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves FrameDecorations from Display to WindowManagerState The FrameDecoration values come from the windowmanager, which is per user. So, move FrameDecorations from Display to WindowManagerState. This also introduces a UserDisplayManager to track the per user display state. BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37 Cr-Commit-Position: refs/heads/master@{#379668}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -194 lines) Patch
M components/mus/mus_app.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M components/mus/ws/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/mus/ws/connection_manager.h View 1 11 chunks +3 lines, -34 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 1 8 chunks +8 lines, -107 lines 0 comments Download
M components/mus/ws/display.h View 4 chunks +14 lines, -11 lines 0 comments Download
M components/mus/ws/display.cc View 7 chunks +40 lines, -23 lines 0 comments Download
M components/mus/ws/display_manager.h View 5 chunks +14 lines, -0 lines 0 comments Download
M components/mus/ws/display_manager.cc View 1 3 chunks +26 lines, -1 line 0 comments Download
M components/mus/ws/test_utils.h View 1 2 chunks +21 lines, -0 lines 0 comments Download
A components/mus/ws/user_display_manager.h View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A components/mus/ws/user_display_manager.cc View 1 1 chunk +124 lines, -0 lines 0 comments Download
A components/mus/ws/user_display_manager_unittest.cc View 1 chunk +233 lines, -0 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 3 chunks +20 lines, -0 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree.h View 3 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 9 months ago (2016-03-07 21:01:55 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-07 21:42:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775583002/40001
4 years, 9 months ago (2016-03-07 21:52:28 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 22:34:17 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 22:35:15 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37
Cr-Commit-Position: refs/heads/master@{#379668}

Powered by Google App Engine
This is Rietveld 408576698