MIPS: Assembler changes for enabling GrowHeap in Wasm.

MIPS: Assembler changes for enabling GrowHeap in Wasm. 

Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works

[Marija Antic, 2016-03-07 16:42:11]

marija.antic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, gergely.kis@imgtec.com,
ilija.pavlovic@imgtec.com, ivica.bogosavljevic@imgtec.com,
miran.karic@imgtec.com

[Marija Antic, 2016-03-07 16:42:11]

Please take a look at MIPS/MIPS64 changes.

[balazs.kilvady, 2016-03-07 20:02:51]

I think the initial CL should not be part of this CL (we upload only the diff to
the original -- the MIPS part).
I guess it is the port of 'Assembler changes for enabling GrowHeap in Wasm'. If
so then the description should be:

MIPS: Assembler changes for enabling GrowHeap in Wasm.

Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works

[Marija Antic, 2016-03-09 09:14:17]

Description was changed from

==========
MIPS: Port assembler changes for enabling GrowHeap in Wasm

Port assembler changes for GrowHeap in Wasm to MIPS and MIPS64

BUG=
==========

to

==========
MIPS: Assembler changes for enabling GrowHeap in Wasm.

Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works
==========

[Marija Antic, 2016-03-09 09:14:38]

Description was changed from

==========
MIPS: Assembler changes for enabling GrowHeap in Wasm.

Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works
==========

to

==========
Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works
==========

[balazs.kilvady, 2016-03-09 11:00:20]

https://codereview.chromium.org/1775443002/diff/40001/src/mips/assembler-mips...
File src/mips/assembler-mips-inl.h (right):

https://codereview.chromium.org/1775443002/diff/40001/src/mips/assembler-mips...
src/mips/assembler-mips-inl.h:154: 
nits: Please try to follow the order of functions in the corresponding ARM file
as it makes easier to follow/port further changes.

https://codereview.chromium.org/1775443002/diff/40001/src/mips/assembler-mips...
src/mips/assembler-mips-inl.h:156: Address reference, ICacheFlushMode
icache_flush_mode) {
The original commit contains the right MIPS/MIPS64 implementations (in the
correct order). Do we need this?

https://codereview.chromium.org/1775443002/diff/40001/src/mips64/assembler-mi...
File src/mips64/assembler-mips64-inl.h (right):

https://codereview.chromium.org/1775443002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64-inl.h:130: 
Same nit and comment like on the MIPS version.

https://codereview.chromium.org/1775443002/diff/40001/test/cctest/test-wasm-r...
File test/cctest/test-wasm-relocation-disasm-mips.cc (right):

https://codereview.chromium.org/1775443002/diff/40001/test/cctest/test-wasm-r...
test/cctest/test-wasm-relocation-disasm-mips.cc:89:
it.rinfo()->update_wasm_memory_reference(
Please update the parameters of this function (and other parts of the tests if
needed). The same for MIPS64.

[Ilija.Pavlovic1, 2016-03-09 12:41:07]

ilija.pavlovic@imgtec.com changed reviewers:
+ Ilija.Pavlovic@imgtec.com

[Ilija.Pavlovic1, 2016-03-09 12:41:08]

This seems to me OK. Adaptations are done according implementation for ARM in
mentioned CL.

[balazs.kilvady, 2016-03-09 16:54:41]

First line of description is missing, the full description must contain the main
sentence (when a CL landed, the oneline commit message in git will be the first
sentence of the description. The issue title is not added to the git commit), so
the full description:

MIPS: Assembler changes for enabling GrowHeap in Wasm.

Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works

[Marija Antic, 2016-03-10 08:50:40]

Description was changed from

==========
Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works
==========

to

==========
MIPS: Assembler changes for enabling GrowHeap in Wasm. 

Port for https://codereview.chromium.org/1759873002/

Original commit message:
 - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
need to be relocated on a heap change
 - RelocInfo mode recorded for immediates that use the memory buffer as base
 - Tests to verify address patching works
==========

[Marija Antic, 2016-03-10 08:50:41]

marija.antic@imgtec.com changed reviewers:
- Ilija.Pavlovic@imgtec.com

[balazs.kilvady, 2016-03-10 11:59:06]

On 2016/03/09 16:54:41, balazs.kilvady wrote:
> First line of description is missing, the full description must contain the
main
> sentence (when a CL landed, the oneline commit message in git will be the
first
> sentence of the description. The issue title is not added to the git commit),
so
> the full description:
> 
> MIPS: Assembler changes for enabling GrowHeap in Wasm.
> 
> Port for https://codereview.chromium.org/1759873002/
> 
> Original commit message:
>  - New RelocInfo mode WASM_HEAP_OBJECT as a marker for wasm code objects that
> need to be relocated on a heap change
>  - RelocInfo mode recorded for immediates that use the memory buffer as base
>  - Tests to verify address patching works

l-g-t-m. As the original CL is not landed, please inform the author (make a
comment on the original CL's page) about this MIPS version.