MIPS: Assembler changes for enabling GrowHeap in Wasm.

src/mips/assembler-mips-inl.h

 
 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
@@ skipping 133 matching lines @@
   DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
   Assembler::set_target_address_at(isolate_, pc_, host_, target,
                                    icache_flush_mode);
   if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
       host() != NULL && IsCodeTarget(rmode_)) {
     Object* target_code = Code::GetCodeFromTargetAddress(target);
     host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
         host(), this, HeapObject::cast(target_code));
   }
 }
 

[balazs.kilvady, 2016/03/09 11:00:20]

nits: Please try to follow the order of functions in the corresponding ARM file
as it makes easier to follow/port further changes.

+void RelocInfo::update_wasm_memory_reference(
+    Address reference, ICacheFlushMode icache_flush_mode) {

[balazs.kilvady, 2016/03/09 11:00:20]

The original commit contains the right MIPS/MIPS64 implementations (in the
correct order). Do we need this?

+  DCHECK(IsWasmMemoryReference(rmode_));
+  Assembler::set_target_address_at(isolate_, pc_, host_, reference,
+                                   icache_flush_mode);
+}
+
+Address RelocInfo::wasm_memory_reference() {
+  DCHECK(IsWasmMemoryReference(rmode_));
+  return Assembler::target_address_at(pc_, host_);
+}
 
 Address Assembler::target_address_from_return_address(Address pc) {
   return pc - kCallTargetAddressOffset;
 }
 
 
 void Assembler::set_target_internal_reference_encoded_at(Address pc,
                                                          Address target) {
   Instr instr1 = Assembler::instr_at(pc + 0 * Assembler::kInstrSize);
   Instr instr2 = Assembler::instr_at(pc + 1 * Assembler::kInstrSize);
@@ skipping 314 matching lines @@
     CheckBuffer();
   }
   EmitHelper(x, is_compact_branch);
 }
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_MIPS_ASSEMBLER_MIPS_INL_H_