Chromium Code Reviews Chromium Code Reviews
Issue
1775293002:
Revert of Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5 id:80001 of https://c… (Closed)
DescriptionRevert of Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5 id:80001 of https://c… (patchset #1 id:1 of https://codereview.chromium.org/1756003003/ )
Reason for revert:
Please see crbug.com/593209 for details.
Original issue's description:
> Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5 id:80001 of https://codereview.chromium.org/1734203002/ )"
>
> This reverts commit f331574002bdde48e2c8ee0a657f202252548f8e aka https://codereview.chromium.org/1746353002
>
> The crashes that it caused are now fixed by http://crrev.com/1755543002
>
> Original description:
> > Fully (?) fix overflow: auto with delayed scroll updates
> >
> > The scroll delaying code, used by Flexbox, never lays out the
> > parent after the child relayout. This is a problem especially
> > because the layout can add/remove a horizontal scrollbar,
> > which changes the height of the element. A vertical scrollbar
> > has this problem less often, though it sometimes does, especially
> > in case of flex items. As far as I can tell, this never worked
> > correctly since the scroll delaying code existed.
> >
> > This patch changes it so that when we eventually do the scroll info
> > updates, we mark the ancestor chain for layout (up to the outer flexbox)
> > and then call layoutFlexItems again, to do the correct layout.
> >
> > See also the discussion thread at
> > https://groups.google.com/a/chromium.org/d/topic/layout-dev/e7Wzvxu7qiA/discussion
> >
> > BUG=579401, 584363
> >
> > Review URL: https://codereview.chromium.org/1734203002
>
> BUG=579401, 584363, 525316
> R=leviw@chromium.org
>
> Committed: https://crrev.com/0bd7c3283a172513fbd1a7d8cad7ad244b11b60f
> Cr-Commit-Position: refs/heads/master@{#378896}
TBR=leviw@chromium.org,cbiesinger@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=579401, 584363, 525316
Patch Set 1 #Messages
Total messages: 2 (1 generated)
|
