Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 1746353002: Revert of Fully (?) fix overflow: auto with delayed scroll updates (Closed)

Created:
4 years, 9 months ago by lfg
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fully (?) fix overflow: auto with delayed scroll updates (patchset #5 id:80001 of https://codereview.chromium.org/1734203002/ ) Reason for revert: Crashes in blink::LayoutObject::container. See https://crbug.com/525316. Original issue's description: > Fully (?) fix overflow: auto with delayed scroll updates > > The scroll delaying code, used by Flexbox, never lays out the > parent after the child relayout. This is a problem especially > because the layout can add/remove a horizontal scrollbar, > which changes the height of the element. A vertical scrollbar > has this problem less often, though it sometimes does, especially > in case of flex items. As far as I can tell, this never worked > correctly since the scroll delaying code existed. > > This patch changes it so that when we eventually do the scroll info > updates, we mark the ancestor chain for layout (up to the outer flexbox) > and then call layoutFlexItems again, to do the correct layout. > > See also the discussion thread at > https://groups.google.com/a/chromium.org/d/topic/layout-dev/e7Wzvxu7qiA/discussion > > BUG=579401, 584363 > > Committed: https://crrev.com/775378f6ac8293e20a393c5203f5431a4a679339 > Cr-Commit-Position: refs/heads/master@{#377826} TBR=leviw@chromium.org,skobes@chromium.org,szager@chromium.org,cbiesinger@google.com,cbiesinger@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=579401, 584363 Committed: https://crrev.com/f331574002bdde48e2c8ee0a657f202252548f8e Cr-Commit-Position: refs/heads/master@{#378382}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
lfg
Created Revert of Fully (?) fix overflow: auto with delayed scroll updates
4 years, 9 months ago (2016-02-29 23:45:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746353002/1
4 years, 9 months ago (2016-02-29 23:45:54 UTC) #2
leviw_travelin_and_unemployed
I don't think this revert is the right thing to do. Let's discuss it on ...
4 years, 9 months ago (2016-02-29 23:51:42 UTC) #4
leviw_travelin_and_unemployed
lgtm I've changed my tune after verifying this is the issue. Hopefully cbiesinger can get ...
4 years, 9 months ago (2016-03-01 00:22:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746353002/1
4 years, 9 months ago (2016-03-01 00:23:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 03:13:21 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 03:14:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f331574002bdde48e2c8ee0a657f202252548f8e
Cr-Commit-Position: refs/heads/master@{#378382}

Powered by Google App Engine
This is Rietveld 408576698