net/quic/quic_http_stream.cc - Issue 1775283002: [Domain Reliabiliy: net stack] Plumb received go away from server due to connection migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_http_stream.cc

Issue 1775283002: [Domain Reliabiliy: net stack] Plumb received go away from server due to connection migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test in quic_stream_factory_test: go away with migration with port only Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/quic/quic_chromium_client_session.h ('K') | « net/quic/quic_chromium_client_session.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | net/quic/quic_stream_factory_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/quic_http_stream.cc

diff --git a/net/quic/quic_http_stream.cc b/net/quic/quic_http_stream.cc

index 5578bd67b718c9576e8d2cee44d945e59fef6b21..1df721a301419dd1f1d7c37e3cdc3d948a2ffce4 100644

--- a/net/quic/quic_http_stream.cc

+++ b/net/quic/quic_http_stream.cc

@@ -437,6 +437,7 @@ void QuicHttpStream::PopulateNetErrorDetails(NetErrorDetails* details) {

details->connection_info = HttpResponseInfo::CONNECTION_INFO_QUIC1_SPDY3;

if (was_handshake_confirmed_)

details->quic_connection_error = quic_connection_error_;

+ stream_request_.PopulateNetErrorDetails(details);

Ryan Hamilton 2016/03/10 22:46:44 Instead of asking the stream_request_ to ask the s

Zhongyi Shi 2016/03/11 03:56:32 Yes, we can, I knew there's a stream_request_ in q

}

void QuicHttpStream::SetPriority(RequestPriority priority) {

« net/quic/quic_chromium_client_session.h ('K') | « net/quic/quic_chromium_client_session.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | net/quic/quic_stream_factory_test.cc » ('J')