Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: net/quic/quic_chromium_client_session.cc

Issue 1775283002: [Domain Reliabiliy: net stack] Plumb received go away from server due to connection migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test in quic_stream_factory_test: go away with migration with port only Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_chromium_client_session.cc
diff --git a/net/quic/quic_chromium_client_session.cc b/net/quic/quic_chromium_client_session.cc
index 15ec708d5f4c8df66dd85ad4db6eea3e37c19fc4..634ba69ef1e8c92086a066924cbb110d3c829b00 100644
--- a/net/quic/quic_chromium_client_session.cc
+++ b/net/quic/quic_chromium_client_session.cc
@@ -157,6 +157,12 @@ void QuicChromiumClientSession::StreamRequest::CancelRequest() {
callback_.Reset();
}
+void QuicChromiumClientSession::StreamRequest::PopulateNetErrorDetails(
+ NetErrorDetails* details) {
+ if (session_)
+ session_->PopulateNetErrorDetails(details);
+}
+
void QuicChromiumClientSession::StreamRequest::OnRequestCompleteSuccess(
QuicChromiumClientStream* stream) {
session_.reset();
@@ -205,6 +211,7 @@ QuicChromiumClientSession::QuicChromiumClientSession(
std::move(socket_performance_watcher),
net_log_)),
going_away_(false),
+ received_goaway_because_of_migrating_port_(false),
disabled_reason_(QUIC_DISABLED_NOT),
token_binding_signatures_(kTokenBindingSignatureMapSize),
weak_factory_(this) {
@@ -760,6 +767,8 @@ void QuicChromiumClientSession::OnCryptoHandshakeMessageReceived(
void QuicChromiumClientSession::OnGoAway(const QuicGoAwayFrame& frame) {
QuicSession::OnGoAway(frame);
NotifyFactoryOfSessionGoingAway();
+ received_goaway_because_of_migrating_port_ =
+ frame.error_code == QUIC_ERROR_MIGRATING_PORT;
}
void QuicChromiumClientSession::OnRstStream(const QuicRstStreamFrame& frame) {
@@ -1098,6 +1107,12 @@ bool QuicChromiumClientSession::MigrateToSocket(
return true;
}
+void QuicChromiumClientSession::PopulateNetErrorDetails(
+ NetErrorDetails* details) {
+ details->received_goaway_because_of_migrating_port =
+ received_goaway_because_of_migrating_port_;
+}
+
const DatagramClientSocket* QuicChromiumClientSession::GetDefaultSocket()
const {
DCHECK(sockets_.back().get() != nullptr);

Powered by Google App Engine
This is Rietveld 408576698