chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

index 8c15b985fdcefb1ea37bd2f0076e4f84165ca196..3d5b36b5666c1a047f1db550ec968a9fb3e15491 100644

--- a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

@@ -18,6 +18,7 @@

#include "grit/theme_resources.h"

#import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

#import "ui/base/cocoa/base_view.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

#import "ui/base/cocoa/flipped_view.h"

#include "ui/base/resource/resource_bundle.h"

@@ -148,7 +149,7 @@ NSPoint GetAnchorPoint(content::RenderWidgetHost* widget_host,

NSRect cocoaRect = [view flipRectToNSRect:anchor_in_root_view];

NSRect windowRect = [view convertRect:cocoaRect toView:nil];

NSPoint point = NSMakePoint(NSMidX(windowRect), NSMinY(windowRect));

- return [[view window] convertBaseToScreen:point];

+ return ui::ConvertPointFromWindowToScreen([view window], point);

}

ValidationMessageBubbleCocoa::ValidationMessageBubbleCocoa(