chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm ('k') | chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm b/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

index 975b0b3af98384790d5b1b29a1df8bfdcaf6e4f4..ada04dd99662ef72b97d8e80f97fec0fc73abc6f 100644

--- a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

@@ -21,6 +21,7 @@

#include "components/translate/core/browser/translate_ui_delegate.h"

#include "content/public/browser/browser_context.h"

#include "grit/components_strings.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

#import "ui/base/cocoa/controls/hyperlink_button_cell.h"

#import "ui/base/cocoa/window_size_constants.h"

#include "ui/base/l10n/l10n_util.h"

@@ -166,7 +167,8 @@ const CGFloat kContentWidth = kWindowWidth - 2 * kFramePadding;

- (void)showWindow:(id)sender {

BrowserWindowController* controller = [[self parentWindow] windowController];

NSPoint anchorPoint = [[controller toolbarController] translateBubblePoint];

- anchorPoint = [[self parentWindow] convertBaseToScreen:anchorPoint];

+ anchorPoint =

+ ui::ConvertPointFromWindowToScreen([self parentWindow], anchorPoint);

[self setAnchorPoint:anchorPoint];

[super showWindow:sender];

}