Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1775133003: Moves EventDispatcher from Display to WindowManagerState (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves EventDispatcher from Display to WindowManagerState EventDispatcher maintains state that is per WindowManager (accelerators, root...), so it makes sense that the EventDispatcher is owned by the WindowManagerState. This patch also makes Display update WindowManagerState and EventDispatcher appropriately when the active user changes. When the active user changes capture and any other event related state is reset. BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8 Cr-Commit-Position: refs/heads/master@{#380005}

Patch Set 1 #

Patch Set 2 : todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+742 lines, -408 lines) Patch
M components/mus/ws/connection_manager.h View 3 chunks +1 line, -4 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/mus/ws/display.h View 10 chunks +11 lines, -69 lines 0 comments Download
M components/mus/ws/display.cc View 10 chunks +55 lines, -230 lines 0 comments Download
M components/mus/ws/display_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/mus/ws/display_manager.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/mus/ws/display_manager_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/display_unittest.cc View 2 chunks +88 lines, -0 lines 0 comments Download
M components/mus/ws/event_dispatcher.h View 3 chunks +14 lines, -1 line 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 4 chunks +46 lines, -8 lines 0 comments Download
M components/mus/ws/test_utils.h View 3 chunks +40 lines, -3 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M components/mus/ws/user_id_tracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/ws/user_id_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/user_id_tracker_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_manager_factory_registry.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_manager_factory_registry.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/ws/window_manager_state.h View 1 3 chunks +107 lines, -6 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 2 chunks +272 lines, -18 lines 0 comments Download
M components/mus/ws/window_tree.h View 2 chunks +10 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree.cc View 9 chunks +47 lines, -39 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-08 22:34:36 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-09 00:50:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775133003/20001
4 years, 9 months ago (2016-03-09 00:53:40 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 01:03:14 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:04:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8
Cr-Commit-Position: refs/heads/master@{#380005}

Powered by Google App Engine
This is Rietveld 408576698