Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1775083002: [turbofan] Fix register constraint for memory barrier. (Closed)

Created:
4 years, 9 months ago by Jarin
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix register constraint for memory barrier. After fixing the memory barrier for maps (https://codereview.chromium.org/1714513003), we are using a temp register for the map case. The temp register should not be aliased with the stored value (otherwise we perform the mem barrier check with a wrong value). This CL makes sure it is not aliased. BUG=chromium:590074 LOG=n Committed: https://crrev.com/9867a8a26ecf3247fd73890ccf34fbc5776ed689 Cr-Commit-Position: refs/heads/master@{#34607}

Patch Set 1 #

Patch Set 2 : Fix other platforms, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -27 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
A test/mjsunit/regress/regress-590074.js View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Jarin
Could you take a look, please?
4 years, 9 months ago (2016-03-08 19:17:51 UTC) #2
Benedikt Meurer
Nice. LGTM
4 years, 9 months ago (2016-03-08 19:19:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775083002/1
4 years, 9 months ago (2016-03-08 19:27:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12047)
4 years, 9 months ago (2016-03-08 19:31:52 UTC) #8
Michael Starzinger
LGTM. Ouch, nice catch!
4 years, 9 months ago (2016-03-09 09:08:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775083002/20001
4 years, 9 months ago (2016-03-09 09:12:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 09:13:54 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 09:39:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9867a8a26ecf3247fd73890ccf34fbc5776ed689
Cr-Commit-Position: refs/heads/master@{#34607}

Powered by Google App Engine
This is Rietveld 408576698