Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 1775083002: [turbofan] Fix register constraint for memory barrier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix other platforms, too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 inputs[input_count++] = g.UseUniqueRegister(base); 367 inputs[input_count++] = g.UseUniqueRegister(base);
368 // OutOfLineRecordWrite uses the index in an 'add' instruction as well as 368 // OutOfLineRecordWrite uses the index in an 'add' instruction as well as
369 // for the store itself, so we must check compatibility with both. 369 // for the store itself, so we must check compatibility with both.
370 if (g.CanBeImmediate(index, kArmAdd) && g.CanBeImmediate(index, kArmStr)) { 370 if (g.CanBeImmediate(index, kArmAdd) && g.CanBeImmediate(index, kArmStr)) {
371 inputs[input_count++] = g.UseImmediate(index); 371 inputs[input_count++] = g.UseImmediate(index);
372 addressing_mode = kMode_Offset_RI; 372 addressing_mode = kMode_Offset_RI;
373 } else { 373 } else {
374 inputs[input_count++] = g.UseUniqueRegister(index); 374 inputs[input_count++] = g.UseUniqueRegister(index);
375 addressing_mode = kMode_Offset_RR; 375 addressing_mode = kMode_Offset_RR;
376 } 376 }
377 inputs[input_count++] = (write_barrier_kind == kMapWriteBarrier) 377 inputs[input_count++] = g.UseUniqueRegister(value);
378 ? g.UseRegister(value)
379 : g.UseUniqueRegister(value);
380 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny; 378 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;
381 switch (write_barrier_kind) { 379 switch (write_barrier_kind) {
382 case kNoWriteBarrier: 380 case kNoWriteBarrier:
383 UNREACHABLE(); 381 UNREACHABLE();
384 break; 382 break;
385 case kMapWriteBarrier: 383 case kMapWriteBarrier:
386 record_write_mode = RecordWriteMode::kValueIsMap; 384 record_write_mode = RecordWriteMode::kValueIsMap;
387 break; 385 break;
388 case kPointerWriteBarrier: 386 case kPointerWriteBarrier:
389 record_write_mode = RecordWriteMode::kValueIsPointer; 387 record_write_mode = RecordWriteMode::kValueIsPointer;
(...skipping 1343 matching lines...) Expand 10 before | Expand all | Expand 10 after
1733 MachineOperatorBuilder::kFloat64RoundTiesAway | 1731 MachineOperatorBuilder::kFloat64RoundTiesAway |
1734 MachineOperatorBuilder::kFloat32RoundTiesEven | 1732 MachineOperatorBuilder::kFloat32RoundTiesEven |
1735 MachineOperatorBuilder::kFloat64RoundTiesEven; 1733 MachineOperatorBuilder::kFloat64RoundTiesEven;
1736 } 1734 }
1737 return flags; 1735 return flags;
1738 } 1736 }
1739 1737
1740 } // namespace compiler 1738 } // namespace compiler
1741 } // namespace internal 1739 } // namespace internal
1742 } // namespace v8 1740 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698