Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775063002: [Android] Use mb on chromium.linux and tryserver.chromium.android. (Closed)

Created:
4 years, 9 months ago by jbudorick
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, martiniss
CC:
bpastene, chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Use mb on chromium.linux and tryserver.chromium.android. Depends on https://codereview.chromium.org/1774233002/ BUG=576993 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299239

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -41 lines) Patch
M scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_linux.py View 1 6 chunks +6 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_instrumentation_test.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Arm64_Builder__dbg_.json View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder.json View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder__dbg_.json View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Clang_Builder__dbg_.json View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests__dbg_.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_arm64_dbg_recipe.json View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_arm64_dbg_recipe_analyze.json View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_clang_dbg_recipe.json View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_clang_dbg_recipe_analyze.json View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_compile_dbg.json View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_compile_dbg_analyze.json View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_compile_rel.json View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_compile_rel_analyze.json View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_linux_android_dbg_ng.json View 1 2 4 chunks +40 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_linux_android_dbg_ng_analyze.json View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_linux_android_rel_ng.json View 1 2 4 chunks +40 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_linux_android_rel_ng_analyze.json View 1 2 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbudorick
will wait for https://codereview.chromium.org/1773883002/ to land before attempting to land this.
4 years, 9 months ago (2016-03-09 15:26:28 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1775063002/diff/20001/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json File scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json (right): https://codereview.chromium.org/1775063002/diff/20001/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json#newcode135 scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json:135: "GYP_CHROMIUM_NO_ACTION": "1", Ick, the example.py in recipe_modules/chromium depends ...
4 years, 9 months ago (2016-03-09 19:55:49 UTC) #3
martiniss
lgtm https://codereview.chromium.org/1775063002/diff/20001/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json File scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json (right): https://codereview.chromium.org/1775063002/diff/20001/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json#newcode135 scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json:135: "GYP_CHROMIUM_NO_ACTION": "1", On 2016/03/09 at 19:55:49, Dirk Pranke ...
4 years, 9 months ago (2016-03-09 19:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775063002/40001
4 years, 9 months ago (2016-03-11 02:04:13 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 02:07:52 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299239

Powered by Google App Engine
This is Rietveld 408576698