Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1775013004: Rename InputHandler::GESTURE to InputHandler::TOUCHSCREEN (Closed)

Created:
4 years, 9 months ago by dtapuska
Modified:
4 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_regression_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename InputHandler::GESTURE to InputHandler::TOUCHSCREEN Since mouse wheel events will use gestures. Make it clear that this scroll input type was really referring to touchscreen. Rename executed via: sed -i 's/InputHandler::GESTURE/InputHandler::TOUCHSCREEN/g' git cl format BUG=593017 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8 Cr-Commit-Position: refs/heads/master@{#380742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -154 lines) Patch
M cc/input/input_handler.h View 1 chunk +1 line, -4 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 77 chunks +177 lines, -138 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 6 chunks +10 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (12 generated)
dtapuska
4 years, 9 months ago (2016-03-09 16:58:03 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 9 months ago (2016-03-09 21:57:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775013004/1
4 years, 9 months ago (2016-03-11 15:27:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/83645)
4 years, 9 months ago (2016-03-11 16:18:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775013004/1
4 years, 9 months ago (2016-03-11 17:00:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129764)
4 years, 9 months ago (2016-03-11 18:34:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775013004/1
4 years, 9 months ago (2016-03-11 18:54:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129873)
4 years, 9 months ago (2016-03-11 20:25:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775013004/1
4 years, 9 months ago (2016-03-11 20:56:53 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 21:45:13 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 21:46:31 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8
Cr-Commit-Position: refs/heads/master@{#380742}

Powered by Google App Engine
This is Rietveld 408576698