Buffer fix for VkProgram caching

Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963003

Committed: https://skia.googlesource.com/skia/+/910114a35076c6bb2dba21bac4607172a823f641

[jvanverth1, 2016-03-08 18:46:44]

Description was changed from

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare and similar case of overwriting vertex or index
buffers when they're in flight.
==========

to

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare and similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-08 18:52:50]

Description was changed from

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare and similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-08 18:53:01]

Description was changed from

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-08 18:53:15]

jvanverth@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-03-08 19:08:47]

https://codereview.chromium.org/1774963003/diff/1/src/gpu/vk/GrVkProgramDataM...
File src/gpu/vk/GrVkProgramDataManager.cpp (right):

https://codereview.chromium.org/1774963003/diff/1/src/gpu/vk/GrVkProgramDataM...
src/gpu/vk/GrVkProgramDataManager.cpp:200: int arrayCount,
sorry stupid nit in other code, but could you align these?

[jvanverth1, 2016-03-08 19:28:20]

Updated based on offline talk.

https://codereview.chromium.org/1774963003/diff/1/src/gpu/vk/GrVkProgramDataM...
File src/gpu/vk/GrVkProgramDataManager.cpp (right):

https://codereview.chromium.org/1774963003/diff/1/src/gpu/vk/GrVkProgramDataM...
src/gpu/vk/GrVkProgramDataManager.cpp:200: int arrayCount,
On 2016/03/08 19:08:47, egdaniel wrote:
> sorry stupid nit in other code, but could you align these?

Done.

[egdaniel, 2016-03-08 19:31:00]

lgtm

[jvanverth1, 2016-03-08 19:50:21]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-03-08 19:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774963003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774963003/20001

[commit-bot: I haz the power, 2016-03-08 20:09:29]

Description was changed from

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Buffer fix for VkProgram caching

When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/910114a35076c6bb2dba21bac4607172a823f641
==========

[commit-bot: I haz the power, 2016-03-08 20:09:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/910114a35076c6bb2dba21bac4607172a823f641