Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1774783002: Fix a bug in bookmark filtering, add a test (Closed)

Created:
4 years, 9 months ago by bburns
Modified:
4 years, 9 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in bookmark filtering, add a test BUG=592149 Committed: https://crrev.com/8c8dd590eb834e2cee23b159970803e34d669dd0 Cr-Commit-Position: refs/heads/master@{#379927}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fix a bug in bookmark filtering. add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M chrome/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelUnitTest.java View 1 2 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bburns
ianwen: code review dtrainor: OWNERS for chrome/android/BUILD.gn
4 years, 9 months ago (2016-03-08 18:52:08 UTC) #2
David Trainor- moved to gerrit
chrome/android/BUILD.gn lgtm.
4 years, 9 months ago (2016-03-08 18:56:48 UTC) #3
Ian Wen
looks good in general. One question about the test. https://codereview.chromium.org/1774783002/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java File chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java (right): https://codereview.chromium.org/1774783002/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java#newcode24 chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java:24: ...
4 years, 9 months ago (2016-03-08 20:44:27 UTC) #4
bburns
On 2016/03/08 20:44:27, Ian Wen wrote: > looks good in general. One question about the ...
4 years, 9 months ago (2016-03-08 20:48:00 UTC) #5
bburns
On 2016/03/08 20:48:00, bburns wrote: > On 2016/03/08 20:44:27, Ian Wen wrote: > > looks ...
4 years, 9 months ago (2016-03-08 20:57:08 UTC) #6
Ian Wen
lgtm. Thank you!
4 years, 9 months ago (2016-03-08 20:58:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774783002/40001
4 years, 9 months ago (2016-03-08 21:55:13 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 22:04:13 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 22:05:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8c8dd590eb834e2cee23b159970803e34d669dd0
Cr-Commit-Position: refs/heads/master@{#379927}

Powered by Google App Engine
This is Rietveld 408576698