chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java - Issue 1774783002: Fix a bug in bookmark filtering, add a test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

Issue 1774783002: Fix a bug in bookmark filtering, add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a bug in bookmark filtering. add tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelUnitTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

index f231e7500a5f4e2bfd836beccd96e220e5e57c33..bb713d00937d1a638a67b07307ccfed52d07bb43 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

@@ -322,8 +322,8 @@ public class BookmarkModel extends BookmarkBridge {

* @return The bookmark id contained in the specified client id.

public static BookmarkId getBookmarkIdForOfflineClientId(ClientId id) {

- if (id.getNamespace() != OfflinePageBridge.BOOKMARK_NAMESPACE) {

- return new BookmarkId(BookmarkType.NORMAL, -1);

+ if (!id.getNamespace().equals(OfflinePageBridge.BOOKMARK_NAMESPACE)) {

+ return new BookmarkId(-1, BookmarkType.NORMAL);

}

return BookmarkId.getBookmarkIdFromString(id.getId());

}