chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js - Issue 1774743002: Fix some ChromeVox Closure compiler errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

Issue 1774743002: Fix some ChromeVox Closure compiler errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js ('k') | chrome/browser/resources/chromeos/chromevox/walkers/table_walker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

diff --git a/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js b/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

index b30dc530aac2d8c24501b57972b1f278aa361dd3..351f167f22226508984acb33eb36a1af364bff71 100644

--- a/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

+++ b/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

@@ -172,11 +172,14 @@ cvox.LayoutLineWalker.prototype.isVisualLineBreak_ = function(lSel, rSel) {

* Determines if node should force a line break.

* This is used for elements with unusual semantics, such as multi-line

* text fields, where the behaviour would otherwise be confusing.

- * @param {!Node} node Node.

+ * @param {Node} node Node.

* @return {boolean} True if the node should appear next to a line break.

* @private

cvox.LayoutLineWalker.prototype.wantsOwnLine_ = function(node) {

+ if (!node) {

+ return false;

+ }

return node instanceof HTMLTextAreaElement ||

node.parentNode instanceof HTMLTextAreaElement;

};