chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js - Issue 1774743002: Fix some ChromeVox Closure compiler errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js

Issue 1774743002: Fix some ChromeVox Closure compiler errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/traverse_table.js ('k') | chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js

diff --git a/chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js b/chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js

index 19faec63ec99dc1e6646ff9fdc9488fb675cb1b0..f360aefc0586b739b67e7ea8fc4ae13bdcc7d590 100644

--- a/chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js

+++ b/chrome/browser/resources/chromeos/chromevox/walkers/abstract_node_walker.js

@@ -39,7 +39,9 @@ goog.inherits(cvox.AbstractNodeWalker, cvox.AbstractWalker);

cvox.AbstractNodeWalker.prototype.next = function(sel) {

var r = sel.isReversed();

var node = sel.end.node || document.body;

+ if (!node) {

+ return null;

+ }

do {

node = cvox.DomUtil.directedNextLeafLikeNode(node, r,

goog.bind(this.stopNodeDescent, this));

@@ -87,7 +89,7 @@ cvox.AbstractNodeWalker.prototype.privateSync_ = function(sel) {

node = node.parentNode;

}

- while (!this.stopNodeDescent(node)) {

+ while (node && !this.stopNodeDescent(node)) {

node = cvox.DomUtil.directedFirstChild(node, r);

}