Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1774673002: Remove DidCommitCompositorFrame from RenderViewObserver.

Created:
4 years, 9 months ago by Avi (use Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wv4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DidCommitCompositorFrame from RenderViewObserver. BUG=583347 TEST=all green CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M content/public/renderer/render_view_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/visual_state_browsertest.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1771043002 Patch 1

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774673002/1
4 years, 9 months ago (2016-03-07 22:27:53 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/126513) linux_chromium_clobber_rel_ng on ...
4 years, 9 months ago (2016-03-07 22:34:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774673002/1
4 years, 9 months ago (2016-03-07 22:38:46 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/32629) cast_shell_android on ...
4 years, 9 months ago (2016-03-07 22:43:25 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774673002/1
4 years, 9 months ago (2016-03-08 02:15:04 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 02:32:39 UTC) #12 
Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

Powered by Google App Engine
This is Rietveld 408576698