Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1771043002: Separate RenderView from RenderWidget, part 4: Painting calls in the delegate. (Closed)

Created:
4 years, 9 months ago by Avi (use Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, nasko, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate RenderView from RenderWidget, part 4: Painting calls in the delegate. BUG=583347 TEST=all green CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/b9dbd97d988b917b7db8209683aa7a0136569e5a Cr-Commit-Position: refs/heads/master@{#379863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M content/renderer/render_view_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/render_widget_owner_delegate.h View 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771043002/1
4 years, 9 months ago (2016-03-07 22:00:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 23:46:04 UTC) #4
Avi (use Gerrit)
Nick, now that you're in, you get these. Nasko, FYI.
4 years, 9 months ago (2016-03-08 02:14:11 UTC) #6
ncarter (slow)
lgtm
4 years, 9 months ago (2016-03-08 17:52:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771043002/1
4 years, 9 months ago (2016-03-08 18:14:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 18:19:43 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 18:21:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9dbd97d988b917b7db8209683aa7a0136569e5a
Cr-Commit-Position: refs/heads/master@{#379863}

Powered by Google App Engine
This is Rietveld 408576698