Teach CRFO:CapturePageText to recognize page refreshes with long delays.

Teach CRFO:CapturePageText to recognize page refreshes with long delays.

In some cases, news sites put longish delays (over 1s) on their
refresh meta tags, in order to update the page periodically.
We should recognize this and not bail (as we used to) on page
text capture on these types of pages -- so that the translate
bubble/bar shows up.

BUG=592360
R=esprehn,jochen

Committed: https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf
Cr-Commit-Position: refs/heads/master@{#379884}

[dglazkov, 2016-03-07 22:02:11]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 22:03:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774663002/1

[commit-bot: I haz the power, 2016-03-07 23:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 23:56:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dglazkov, 2016-03-08 01:16:13]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-03-08 01:16:16]

Added interval.

[commit-bot: I haz the power, 2016-03-08 01:16:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774663002/20001

[dglazkov, 2016-03-08 04:21:27]

Description was changed from

==========
Teach CRFO:CapturePageText to recognize page refreshes with long delays.

In some cases, news sites put longish delays (over 1s) on their
refresh meta tags, in order to update the page periodically.
We should recognize this and not bail (as we used to) on page
text capture on these types of pages -- so that the translate
bubble/bar shows up.

BUG=592360
R=esprehn
==========

to

==========
Teach CRFO:CapturePageText to recognize page refreshes with long delays.

In some cases, news sites put longish delays (over 1s) on their
refresh meta tags, in order to update the page periodically.
We should recognize this and not bail (as we used to) on page
text capture on these types of pages -- so that the translate
bubble/bar shows up.

BUG=592360
R=esprehn,jochen
==========

[dglazkov, 2016-03-08 04:21:37]

dglazkov@chromium.org changed reviewers:
+ jochen@chromium.org

[dglazkov, 2016-03-08 04:21:44]

PTAL.

[commit-bot: I haz the power, 2016-03-08 04:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 04:51:33]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-03-08 05:11:01]

lgtm with comments

https://codereview.chromium.org/1774663002/diff/20001/chrome/renderer/chrome_...
File chrome/renderer/chrome_render_frame_observer.cc (right):

https://codereview.chromium.org/1774663002/diff/20001/chrome/renderer/chrome_...
chrome/renderer/chrome_render_frame_observer.cc:69: static const double
kLocationChangeInterval = 10;
Please add InSeconds

https://codereview.chromium.org/1774663002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebLocalFrame.h (right):

https://codereview.chromium.org/1774663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebLocalFrame.h:145: virtual bool
isNavigationScheduledWithin(double interval) const = 0;
Can you add InSeconds to the argument's name?

[dglazkov, 2016-03-08 05:48:01]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2016-03-08 05:48:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1774663002/#ps40001
(title: "Addressed nits.")

[commit-bot: I haz the power, 2016-03-08 05:48:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774663002/40001

[commit-bot: I haz the power, 2016-03-08 06:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 06:04:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dglazkov, 2016-03-08 19:20:26]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-03-08 19:20:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774663002/40001

[commit-bot: I haz the power, 2016-03-08 19:27:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-08 19:30:28]

Description was changed from

==========
Teach CRFO:CapturePageText to recognize page refreshes with long delays.

In some cases, news sites put longish delays (over 1s) on their
refresh meta tags, in order to update the page periodically.
We should recognize this and not bail (as we used to) on page
text capture on these types of pages -- so that the translate
bubble/bar shows up.

BUG=592360
R=esprehn,jochen
==========

to

==========
Teach CRFO:CapturePageText to recognize page refreshes with long delays.

In some cases, news sites put longish delays (over 1s) on their
refresh meta tags, in order to update the page periodically.
We should recognize this and not bail (as we used to) on page
text capture on these types of pages -- so that the translate
bubble/bar shows up.

BUG=592360
R=esprehn,jochen

Committed: https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf
Cr-Commit-Position: refs/heads/master@{#379884}
==========

[commit-bot: I haz the power, 2016-03-08 19:30:29]

Patchset 3 (id:??) landed as
https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf
Cr-Commit-Position: refs/heads/master@{#379884}