Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3577)

Unified Diff: chrome/browser/translate/translate_browsertest.cc

Issue 1774663002: Teach CRFO:CapturePageText to recognize page refreshes with long delays. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_browsertest.cc
diff --git a/chrome/browser/translate/translate_browsertest.cc b/chrome/browser/translate/translate_browsertest.cc
index 2afe85aa86d3aace1ed93d2737b1c45bb1a73891..d8f5f332b9fecf3191d7b6f8dda5d59c2c8b1f2d 100644
--- a/chrome/browser/translate/translate_browsertest.cc
+++ b/chrome/browser/translate/translate_browsertest.cc
@@ -42,6 +42,7 @@ const base::FilePath::CharType kTranslateRoot[] =
const char kFrenchTestPath[] = "/fr_test.html";
const char kBasicFrenchTestPath[] = "/basic_fr_test.html";
const char kRefreshMetaTagTestPath[] = "/refresh_meta_tag.html";
+const char kRefreshMetaTagLongDelayTestPath[] = "/refresh_meta_tag_long.html";
const char kRefreshMetaTagCaseInsensitiveTestPath[] =
"/refresh_meta_tag_casei.html";
const char kRefreshMetaTagAtOnloadTestPath[] =
@@ -274,6 +275,11 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTag) {
kRefreshMetaTagTestPath, false));
}
+IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, TranslateRefreshMetaTagLongDelay) {
+ ASSERT_NO_FATAL_FAILURE(
+ CheckForTranslateUI(kRefreshMetaTagLongDelayTestPath, true));
+}
+
IN_PROC_BROWSER_TEST_F(TranslateBrowserTest,
IgnoreRefreshMetaTagInCaseInsensitive) {
ASSERT_NO_FATAL_FAILURE(CheckForTranslateUI(
« no previous file with comments | « no previous file | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698