components/test_runner/test_plugin.h - Issue 1774653002: Decouple scheduling animation of webview plugins from layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_plugin.h

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/plugins/renderer/webview_plugin.cc ('k') | content/renderer/browser_plugin/browser_plugin.h » ('j') | third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_plugin.h

diff --git a/components/test_runner/test_plugin.h b/components/test_runner/test_plugin.h

index 55c2832279981443f34e0c01327f8b039b6e20f0..65b60e40ff654d8a050bec60a0cdbae054cece78 100644

--- a/components/test_runner/test_plugin.h

+++ b/components/test_runner/test_plugin.h

@@ -63,7 +63,7 @@ class TestPlugin : public blink::WebPlugin, public cc::TextureLayerClient {

NPObject* scriptableObject() override;

bool canProcessDrag() const override;

bool supportsKeyboardFocus() const override;

- void layoutIfNeeded() override {}

+ void updateAllLifecyclePhases() override {}

void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override {}

void updateGeometry(const blink::WebRect& window_rect,

const blink::WebRect& clip_rect,