Create localization files for iOS Share Extension.

Create localization files for iOS Share Extension.

Refactor ios_repack_extension_locales.py to reuse it.

Committed: https://crrev.com/c37a6804b0a4f14d336c31165412715846bd4fdd
Cr-Commit-Position: refs/heads/master@{#380589}

[Olivier, 2016-03-08 17:03:09]

olivierrobin@chromium.org changed reviewers:
+ noyau@chromium.org, sdefresne@chromium.org, stkhapugin@chromium.org

[stkhapugin, 2016-03-08 17:14:00]

lgtm

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
File
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb
(right):

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb:3:
<translationbundle lang="fr">
You know this language, you can fill  at least this one.

[noyau (Ping after 24h), 2016-03-08 18:53:31]

lgtm

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
File
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb
(right):

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb:3:
<translationbundle lang="fr">
On 2016/03/08 17:14:00, stkhapugin wrote:
> You know this language, you can fill  at least this one.

Uh, no. We have teams of translators who are trained to do this…

[stkhapugin, 2016-03-09 17:17:38]

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
File
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb
(right):

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb:3:
<translationbundle lang="fr">
On 2016/03/08 18:53:31, noyau wrote:
> On 2016/03/08 17:14:00, stkhapugin wrote:
> > You know this language, you can fill  at least this one.
> 
> Uh, no. We have teams of translators who are trained to do this…

It was a joke

[noyau (Ping after 24h), 2016-03-09 17:30:17]

On 2016/03/09 17:17:38, stkhapugin wrote:
>
https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
> File
>
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb
> (right):
> 
>
https://codereview.chromium.org/1774623004/diff/1/ios/chrome/share_extension/...
>
ios/chrome/share_extension/strings/resources/ios_share_extension_strings_fr.xtb:3:
> <translationbundle lang="fr">
> On 2016/03/08 18:53:31, noyau wrote:
> > On 2016/03/08 17:14:00, stkhapugin wrote:
> > > You know this language, you can fill  at least this one.
> > 
> > Uh, no. We have teams of translators who are trained to do this…
> 
> It was a joke

Ah, ok, next time put a smiley or do the Russian translation :)

[Olivier, 2016-03-10 13:30:45]

sdefresne: ping

[sdefresne, 2016-03-10 13:48:33]

lgtm

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
File ios/chrome/tools/build/ios_repack_extension_locales.py (right):

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_extension_locales.py:6: """Helper script to
repack paks for a list of locales for extension.
nit: extension -> extensions

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_extension_locales.py:45: #e.g.
'out/Debug/gen/ios/%extension_name%/ios_%extension_name%_strings_da.pak'
nit: %variable% is unusual on un*x, can you change this to ${extension} (shell),
<(extension) (gyp) or %(extension)s (python)?

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_extension_locales.py:46:
inputs.append(os.path.join(
nit: keep the original formatting

  inputs.append(os.path.join('ios', options.extension_name,
                'ios_%s_strings_%s.pak' % (options.extensaion_name, locale)))

https://codereview.chromium.org/1774623004/diff/1/tools/gritsettings/resource...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1774623004/diff/1/tools/gritsettings/resource...
tools/gritsettings/resource_ids:209:
"ios/chrome/share_extension/strings/ios_share_extension_strings.grd": {
nit: can you move above ios_today_extension_strings to sort both alphabetically
and by ids?

[Olivier, 2016-03-10 14:31:16]

Thanks

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
File ios/chrome/tools/build/ios_repack_extension_locales.py (right):

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_extension_locales.py:6: """Helper script to
repack paks for a list of locales for extension.
On 2016/03/10 13:48:33, sdefresne wrote:
> nit: extension -> extensions

Done.

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_extension_locales.py:45: #e.g.
'out/Debug/gen/ios/%extension_name%/ios_%extension_name%_strings_da.pak'
On 2016/03/10 13:48:33, sdefresne wrote:
> nit: %variable% is unusual on un*x, can you change this to ${extension}
(shell),
> <(extension) (gyp) or %(extension)s (python)?

Done.

https://codereview.chromium.org/1774623004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_extension_locales.py:46:
inputs.append(os.path.join(
On 2016/03/10 13:48:33, sdefresne wrote:
> nit: keep the original formatting
> 
>   inputs.append(os.path.join('ios', options.extension_name,
>                 'ios_%s_strings_%s.pak' % (options.extensaion_name, locale)))

It does not fit, so I put it on next line.

https://codereview.chromium.org/1774623004/diff/1/tools/gritsettings/resource...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1774623004/diff/1/tools/gritsettings/resource...
tools/gritsettings/resource_ids:209:
"ios/chrome/share_extension/strings/ios_share_extension_strings.grd": {
On 2016/03/10 13:48:33, sdefresne wrote:
> nit: can you move above ios_today_extension_strings to sort both
alphabetically
> and by ids?

Done.

[sdefresne, 2016-03-10 14:35:10]

lgtm

[Olivier, 2016-03-10 14:37:41]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2016-03-10 14:37:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org, noyau@chromium.org
Link to the patchset: https://codereview.chromium.org/1774623004/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2016-03-10 14:38:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774623004/20001

[commit-bot: I haz the power, 2016-03-10 14:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 14:48:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Olivier, 2016-03-10 14:50:42]

olivierrobin@chromium.org changed reviewers:
+ thakis@chromium.org

[Olivier, 2016-03-10 14:50:43]

+thakis for grit owner.

[Nico, 2016-03-10 18:17:09]

lgtm

[Olivier, 2016-03-11 08:19:42]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2016-03-11 08:19:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774623004/20001

[commit-bot: I haz the power, 2016-03-11 09:50:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 09:51:47]

Description was changed from

==========
Create localization files for iOS Share Extension.

Refactor ios_repack_extension_locales.py to reuse it.
==========

to

==========
Create localization files for iOS Share Extension.

Refactor ios_repack_extension_locales.py to reuse it.

Committed: https://crrev.com/c37a6804b0a4f14d336c31165412715846bd4fdd
Cr-Commit-Position: refs/heads/master@{#380589}
==========

[commit-bot: I haz the power, 2016-03-11 09:51:48]

Patchset 2 (id:??) landed as
https://crrev.com/c37a6804b0a4f14d336c31165412715846bd4fdd
Cr-Commit-Position: refs/heads/master@{#380589}