Create localization files for iOS Share Extension.

ios/chrome/tools/build/ios_repack_extension_locales.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-"""Helper script to repack paks for a list of locales for today extension.
+"""Helper script to repack paks for a list of locales for extension.

[sdefresne, 2016/03/10 13:48:33]

nit: extension -> extensions

[Olivier, 2016/03/10 14:31:15]

Done.

 
 Gyp doesn't have any built-in looping capability, so this just provides a way to
 loop over a list of locales when repacking pak files, thus avoiding a
 proliferation of mostly duplicate, cut-n-paste gyp actions.
 """
 
 import optparse
 import os
 import sys
 
@@ skipping 18 matching lines @@
     locale = 'en'
   else:
     locale = locale.replace('-', '_')
   return os.path.join(options.out_dir, locale + '.lproj', 'locale.pak')
 
 
 def calc_inputs(options, locale):
   """Determine the files that need processing for the given locale."""
   inputs = []
 
-  #e.g. 'out/Debug/gen/ios/today_extension/ios_today_extension_strings_da.pak'
-  inputs.append(os.path.join(options.share_int_dir, 'ios', 'today_extension',
-                'ios_today_extension_strings_%s.pak' % (locale)))
+  #e.g. 'out/Debug/gen/ios/%extension_name%/ios_%extension_name%_strings_da.pak'

[sdefresne, 2016/03/10 13:48:33]

nit: %variable% is unusual on un*x, can you change this to ${extension} (shell),
<(extension) (gyp) or %(extension)s (python)?

[Olivier, 2016/03/10 14:31:16]

Done.

+  inputs.append(os.path.join(

[sdefresne, 2016/03/10 13:48:33]

nit: keep the original formatting

  inputs.append(os.path.join('ios', options.extension_name,
                'ios_%s_strings_%s.pak' % (options.extensaion_name, locale)))

[Olivier, 2016/03/10 14:31:15]

It does not fit, so I put it on next line.

+      options.share_int_dir,
+      'ios',
+      options.extension_name,
+      'ios_%s_strings_%s.pak' % (options.extension_name, locale)))
 
   # Add any extra input files.
   for extra_file in options.extra_input:
     inputs.append('%s_%s.pak' % (extra_file, locale))
 
   return inputs
 
 
 def list_outputs(options, locales):
   """Returns the names of files that will be generated for the given locales.
@@ skipping 44 matching lines @@
   parser.add_option(
       "-x", action="store", dest="out_dir",
       help="Intermediate build files output directory.")
   parser.add_option(
       "-s", action="store", dest="share_int_dir",
       help="Shared intermediate build files output directory.")
   parser.add_option(
       "-b", action="store", dest="branding",
       help="Branding type of this build.")
   parser.add_option(
+      "-n", action="store", dest="extension_name",
+      help="Name of the extension.")
+  parser.add_option(
       "-e", action="append", dest="extra_input", default=[],
       help="Full path to an extra input pak file without the "
            "locale suffix and \".pak\" extension.")
   parser.add_option(
       "--whitelist", action="store", help="Full path to the "
       "whitelist used to filter output pak file resource IDs")
   options, locales = parser.parse_args(argv)
 
   if not locales:
     parser.error('Please specificy at least one locale to process.\n')
 
+  if not options.extension_name:
+    parser.error('Please specificy extension name.\n')
+
   if not (options.out_dir and options.share_int_dir):
     parser.error('Please specify all of "-x" and "-s".\n')
   if options.print_inputs and options.print_outputs:
     parser.error('Please specify only one of "-i" or "-o".\n')
   # Need to know the branding, unless we're just listing the outputs.
   if not options.print_outputs and not options.branding:
     parser.error('Please specify "-b" to determine the input files.\n')
 
   if options.print_inputs:
     return quote_filenames(list_inputs(options, locales))
 
   if options.print_outputs:
     return quote_filenames(list_outputs(options, locales))
 
   return repack_locales(options, locales)
 
 if __name__ == '__main__':
   results = DoMain(sys.argv[1:])
   if results:
     print results