[regexp] extend property classes by script category.

[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}

Committed: https://crrev.com/13d18c0079fb527698444aeb8d9c58a3764bd13d
Cr-Commit-Position: refs/heads/master@{#34562}

[Dan Ehrenberg, 2016-03-07 15:34:54]

lgtm

Looks great. Note that some blocks (when you get to them) overlap in names with
scripts, and .NET's solution (proposed for inclusion in JS) is to use In* as a
prefix IIRC.

https://codereview.chromium.org/1774513002/diff/1/src/regexp/regexp-parser.cc
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/1774513002/diff/1/src/regexp/regexp-parser.cc...
src/regexp/regexp-parser.cc:868: if (category == UCHAR_INVALID_CODE) continue;
We could consider replacing this linear search with a hash table at some point,
but I guess it's fine for now.

[Yang, 2016-03-07 17:16:41]

Dont you mean "Is" as prefix? I saw the example IsCyrillic.

https://codereview.chromium.org/1774513002/diff/1/src/regexp/regexp-parser.cc
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/1774513002/diff/1/src/regexp/regexp-parser.cc...
src/regexp/regexp-parser.cc:868: if (category == UCHAR_INVALID_CODE) continue;
On 2016/03/07 15:34:54, Dan Ehrenberg wrote:
> We could consider replacing this linear search with a hash table at some
point,
> but I guess it's fine for now.

Acknowledged.

[Yang, 2016-03-07 17:16:47]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-03-07 17:16:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774513002/1

[commit-bot: I haz the power, 2016-03-07 17:39:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-07 17:40:29]

Description was changed from

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N
==========

to

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}
==========

[commit-bot: I haz the power, 2016-03-07 17:40:33]

Patchset 1 (id:??) landed as
https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}

[Yang, 2016-03-07 18:11:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1772563003/ by yangguo@chromium.org.

The reason for reverting is: wrong noi18n expectations.

[Yang, 2016-03-07 19:33:07]

Description was changed from

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}
==========

to

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}
==========

[Yang, 2016-03-07 19:35:48]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-03-07 19:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1774513002/#ps20001
(title: "adapt expectations")

[commit-bot: I haz the power, 2016-03-07 19:35:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774513002/20001

[commit-bot: I haz the power, 2016-03-07 20:09:25]

Description was changed from

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}
==========

to

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}
==========

[commit-bot: I haz the power, 2016-03-07 20:09:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 20:10:59]

Description was changed from

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}
==========

to

==========
[regexp] extend property classes by script category.

R=littledan@chromium.org
BUG=v8:4743
LOG=N

Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655
Cr-Commit-Position: refs/heads/master@{#34553}

Committed: https://crrev.com/13d18c0079fb527698444aeb8d9c58a3764bd13d
Cr-Commit-Position: refs/heads/master@{#34562}
==========

[commit-bot: I haz the power, 2016-03-07 20:11:00]

Patchset 2 (id:??) landed as
https://crrev.com/13d18c0079fb527698444aeb8d9c58a3764bd13d
Cr-Commit-Position: refs/heads/master@{#34562}