Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1772563003: Revert of [regexp] extend property classes by script category. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] extend property classes by script category. (patchset #1 id:1 of https://codereview.chromium.org/1774513002/ ) Reason for revert: wrong noi18n expectations Original issue's description: > [regexp] extend property classes by script category. > > R=littledan@chromium.org > BUG=v8:4743 > LOG=N > > Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655 > Cr-Commit-Position: refs/heads/master@{#34553} TBR=littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4743 Committed: https://crrev.com/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89 Cr-Commit-Position: refs/heads/master@{#34554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -153 lines) Patch
M src/char-predicates.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/char-predicates-inl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 chunk +38 lines, -45 lines 0 comments Download
D test/mjsunit/harmony/regexp-property-general-category.js View 1 chunk +0 lines, -64 lines 0 comments Download
D test/mjsunit/harmony/regexp-property-script-category.js View 1 chunk +0 lines, -39 lines 0 comments Download
A test/mjsunit/harmony/unicode-regexp-property-class.js View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
Created Revert of [regexp] extend property classes by script category.
4 years, 9 months ago (2016-03-07 18:11:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772563003/1
4 years, 9 months ago (2016-03-07 18:11:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 18:12:01 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 18:16:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7dc13c2a8cc44c0ec58e31caaa17653e9d2e5a89
Cr-Commit-Position: refs/heads/master@{#34554}

Powered by Google App Engine
This is Rietveld 408576698