[DevTools] Roll closure compiler to ToT version

[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=alph@chromium.org, caseq@chromium.org, lushnikov@chromium.org, dgozman@chromium.org
TBR=sergeyv@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c

[kozy, 2016-03-07 22:30:39]

Description was changed from

==========
[DevTools] Roll closure compiler to ToT version

Array.prototype.push supports type checking after closure compiler roll.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
==========

to

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
==========

[kozy, 2016-03-07 22:36:34]

Description was changed from

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
==========

to

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
==========

[kozy, 2016-03-07 22:37:36]

ptal!

[kozy, 2016-03-08 02:57:43]

Uploaded better approach!
Please take a look!

[lushnikov, 2016-03-08 20:01:49]

lushnikov@chromium.org changed reviewers:
+ alph@chromium.org

[lushnikov, 2016-03-08 20:01:50]

awesome! lgtm!

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
(right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js:532:
this.allChildren(parent).push(/** @type {!WebInspector.HeapSnapshotGridNode}
*/(node));
over to @alph

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
(right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:846:
this._entryData.push(/** @type {!WebInspector.TimelineIRModel.Phases}
*/(segment.data));
over to @alph

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java
(right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java:109:
// because its constructor should be executed on one thread.
on a single thread

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java:110:
// Constructor is parsing flags and create options object that can be used
creating

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java:111:
// later in parallel threads during compilation.
-threads

[caseq, 2016-03-08 20:08:24]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-03-08 20:08:25]

timelime/ & DataGrid.js lgtm

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:102: var
columnIdentifier = column.identifier = column.id || "" + i;
nit: String(i)

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:223: var
columnIdentifier = column.identifier || "" + i;
ditto

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:723: if
(columnsVisibility[column.identifier || "" + i])
ditto

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1242:
this._element.appendChild(this.createCell(columnsArray[i].identifier || "" +
i));
ditto

[alph, 2016-03-08 20:12:19]

lgtm

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
(right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js:528:
* @param {!WebInspector.DataGridNode} node
Can we update the type of this arg instead.

[kozy, 2016-03-08 20:28:55]

Thanks!
All done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
(right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js:528:
* @param {!WebInspector.DataGridNode} node
On 2016/03/08 20:12:19, alph wrote:
> Can we update the type of this arg instead.

Done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:223: var
columnIdentifier = column.identifier || "" + i;
On 2016/03/08 20:08:25, caseq wrote:
> ditto

Done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:723: if
(columnsVisibility[column.identifier || "" + i])
On 2016/03/08 20:08:25, caseq wrote:
> ditto

Done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1242:
this._element.appendChild(this.createCell(columnsArray[i].identifier || "" +
i));
On 2016/03/08 20:08:25, caseq wrote:
> ditto

Done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java
(right):

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java:109:
// because its constructor should be executed on one thread.
On 2016/03/08 20:01:49, lushnikov wrote:
> on a single thread

Done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java:110:
// Constructor is parsing flags and create options object that can be used
On 2016/03/08 20:01:49, lushnikov wrote:
> creating

Done.

https://codereview.chromium.org/1774503005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java:111:
// later in parallel threads during compilation.
On 2016/03/08 20:01:49, lushnikov wrote:
> -threads

Done.

[kozy, 2016-03-08 20:28:59]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-08 20:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org,
lushnikov@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1774503005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-08 20:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774503005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774503005/60001

[commit-bot: I haz the power, 2016-03-08 20:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 20:32:21]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kozy, 2016-03-08 21:53:17]

Description was changed from

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
==========

to

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
TBR=sergeyv@chromium.org
==========

[commit-bot: I haz the power, 2016-03-08 21:57:38]

Description was changed from

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=lushnikov@chromium.org,dgozman@chromium.org
TBR=sergeyv@chromium.org
==========

to

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=alph@chromium.org, caseq@chromium.org, lushnikov@chromium.org,
dgozman@chromium.org
TBR=sergeyv@chromium.org

Committed: https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c
Cr-Commit-Position: refs/heads/master@{#379920}
==========

[commit-bot: I haz the power, 2016-03-08 21:57:40]

Patchset 4 (id:??) landed as
https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c
Cr-Commit-Position: refs/heads/master@{#379920}

[kozy, 2016-03-08 21:58:12]

Description was changed from

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=alph@chromium.org, caseq@chromium.org, lushnikov@chromium.org,
dgozman@chromium.org
TBR=sergeyv@chromium.org

Committed: https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c
Cr-Commit-Position: refs/heads/master@{#379920}
==========

to

==========
[DevTools] Roll closure compiler to ToT version

Closure version:
commit e89bb281f3dbf72c20f1a86e3313831f943be688
Date:   Mon Mar 7 08:27:56 2016 -0800

Array.prototype.push supports type checking.
Better arrow function support.
Removed third_party/WebKit/Source/devtools/front_end/es6.js.

BUG=591865
R=alph@chromium.org, caseq@chromium.org, lushnikov@chromium.org,
dgozman@chromium.org
TBR=sergeyv@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/9441c5e62f2a8caf30b8d5709ad3...
==========

[kozy, 2016-03-08 21:58:14]

Committed patchset #4 (id:60001) manually as
9441c5e62f2a8caf30b8d5709ad374bb1dc6432c (presubmit successful).