third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 1774503005: [DevTools] Roll closure compiler to ToT version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1774503005: [DevTools] Roll closure compiler to ToT version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

index ef01c15f4b744928eccae91b9565bdc83f87d1ad..6faae4b4e18880f4fe70d61baf7df4fe808e2a5d 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -347,7 +347,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

reset: function()

{

WebInspector.TimelineFlameChartDataProviderBase.prototype.reset.call(this);

- /** @type {!Array<!WebInspector.TracingModel.Event|!WebInspector.TimelineFrame|!WebInspector.TimelineIRModel.Phases>} */

+ /** @type {!Array<!WebInspector.TracingModel.Event|!WebInspector.TimelineFrame|!WebInspector.TimelineIRModel.Phases|null>} */

this._entryData = [];

/** @type {!Array<!WebInspector.TimelineFlameChartEntryType>} */

this._entryTypeByLevel = [];

@@ -843,7 +843,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

_appendSegment: function(segment)

{

var index = this._entryData.length;

- this._entryData.push(segment.data);

+ this._entryData.push(/** @type {!WebInspector.TimelineIRModel.Phases} */(segment.data));

this._entryIndexToTitle[index] = /** @type {string} */ (segment.data);

this._timelineData.entryLevels[index] = this._currentLevel;

this._timelineData.entryTotalTimes[index] = segment.end - segment.begin;

@@ -879,7 +879,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

if (this._lastSelection && this._lastSelection.timelineSelection.object() === selection.object())

return this._lastSelection.entryIndex;

- var index = this._entryData.indexOf(selection.object());

+ var index = this._entryData.indexOf(/** @type {!WebInspector.TracingModel.Event|!WebInspector.TimelineFrame|!WebInspector.TimelineIRModel.Phases} */(selection.object()));

if (index !== -1)

this._lastSelection = new WebInspector.TimelineFlameChartView.Selection(selection, index);

return index;