[Autofill] Add the phone extension type.

Adds the phone extension type for autocomplete attributes and server predictions.

BUG=593031
TEST=FormStructureBrowserTest

Committed: https://crrev.com/e6ba074f2fd9f62d45282aaddfe6ba17ad04a34e
Cr-Commit-Position: refs/heads/master@{#380905}

[sebsg, 2016-03-08 15:38:08]

Description was changed from

==========
[Autofill] Add the phone extension type.

Adds the phone extension type for autocomplete attributes and server
predictions.

BUG=593031
TEST=FormStructureBrowserTest
==========

to

==========
Adds the phone extension type for autocomplete attributes and server
predictions.

BUG=593031
TEST=FormStructureBrowserTest
==========

[sebsg, 2016-03-08 15:38:08]

sebsg@chromium.org changed reviewers:
+ kenjitoyama@chromium.org, mathp@chromium.org

[sebsg, 2016-03-08 15:38:57]

Could you please take a look? Thanks!

[Toyama, 2016-03-08 15:44:24]

lgtm

This is great. It should reduce a lot of UNKNOW_TYPEs.

https://codereview.chromium.org/1774153002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/field_types.h (right):

https://codereview.chromium.org/1774153002/diff/1/components/autofill/core/br...
components/autofill/core/browser/field_types.h:156: PHONE_HOME_EXTENSION = 93,
What do you think about grouping this with the other PHONE_HOME_* fields?

[sebsg, 2016-03-08 15:49:22]

Thanks!

https://codereview.chromium.org/1774153002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/field_types.h (right):

https://codereview.chromium.org/1774153002/diff/1/components/autofill/core/br...
components/autofill/core/browser/field_types.h:156: PHONE_HOME_EXTENSION = 93,
On 2016/03/08 15:44:24, Toyama wrote:
> What do you think about grouping this with the other PHONE_HOME_* fields?

I thought about it (and for the cc-names also) but I kept them that way to
preserve the ordering of the numbers. But since we have the MAX_VALID_FIELD_TYPE
to indicate what number to take I think it might be clearer your way. Any
objections Math?

[Mathieu, 2016-03-09 16:58:49]

lgtm

https://codereview.chromium.org/1774153002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/field_types.h (right):

https://codereview.chromium.org/1774153002/diff/1/components/autofill/core/br...
components/autofill/core/browser/field_types.h:156: PHONE_HOME_EXTENSION = 93,
On 2016/03/08 at 15:49:22, sebsg wrote:
> On 2016/03/08 15:44:24, Toyama wrote:
> > What do you think about grouping this with the other PHONE_HOME_* fields?
> 
> I thought about it (and for the cc-names also) but I kept them that way to
preserve the ordering of the numbers. But since we have the MAX_VALID_FIELD_TYPE
to indicate what number to take I think it might be clearer your way. Any
objections Math?

This file is ordered and let's not be the first to create chaos (it wouldn't be
great to have ordered values with exceptions).

[sebsg, 2016-03-09 17:43:23]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2016-03-09 17:43:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774153002/1

[commit-bot: I haz the power, 2016-03-09 18:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 18:15:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sebsg, 2016-03-13 19:58:14]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-03-13 19:58:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
kenjitoyama@chromium.org
Link to the patchset: https://codereview.chromium.org/1774153002/#ps40001
(title: "Rebase and adapt heuristic output")

[commit-bot: I haz the power, 2016-03-13 19:58:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774153002/40001

[commit-bot: I haz the power, 2016-03-13 21:26:11]

Description was changed from

==========
Adds the phone extension type for autocomplete attributes and server
predictions.

BUG=593031
TEST=FormStructureBrowserTest
==========

to

==========
Adds the phone extension type for autocomplete attributes and server
predictions.

BUG=593031
TEST=FormStructureBrowserTest
==========

[commit-bot: I haz the power, 2016-03-13 21:26:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-13 21:27:22]

Description was changed from

==========
Adds the phone extension type for autocomplete attributes and server
predictions.

BUG=593031
TEST=FormStructureBrowserTest
==========

to

==========
Adds the phone extension type for autocomplete attributes and server
predictions.

BUG=593031
TEST=FormStructureBrowserTest

Committed: https://crrev.com/e6ba074f2fd9f62d45282aaddfe6ba17ad04a34e
Cr-Commit-Position: refs/heads/master@{#380905}
==========

[commit-bot: I haz the power, 2016-03-13 21:27:24]

Patchset 3 (id:??) landed as
https://crrev.com/e6ba074f2fd9f62d45282aaddfe6ba17ad04a34e
Cr-Commit-Position: refs/heads/master@{#380905}