components/autofill/core/browser/phone_field.cc - Issue 1774153002: [Autofill] Add the phone extension type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/phone_field.cc

Issue 1774153002: [Autofill] Add the phone extension type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and adapt heuristic output Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/phone_field.cc

diff --git a/components/autofill/core/browser/phone_field.cc b/components/autofill/core/browser/phone_field.cc

index ef815d6603a22057aeb84edf7d07750445daf4a4..0044fcc9fa2b8197713f0256d5e2eb4cc7b5f127 100644

--- a/components/autofill/core/browser/phone_field.cc

+++ b/components/autofill/core/browser/phone_field.cc

@@ -247,10 +247,9 @@ void PhoneField::AddClassifications(

}

if (parsed_phone_fields_[FIELD_EXTENSION]) {

- // TODO(crbug.com/589211): Change from UNKNOWN_TYPE to the proper

- // ServerFieldType once the new phone suffix is checked in.

- AddClassification(parsed_phone_fields_[FIELD_EXTENSION], UNKNOWN_TYPE,

- kBasePhoneParserScore, field_candidates);

+ AddClassification(parsed_phone_fields_[FIELD_EXTENSION],

+ PHONE_HOME_EXTENSION, kBasePhoneParserScore,

+ field_candidates);

}