third_party/third_party.gyp - Issue 1774123005: Support clang-cl build on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/third_party.gyp

Issue 1774123005: Support clang-cl build on Windows. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/third_party.gyp

diff --git a/third_party/third_party.gyp b/third_party/third_party.gyp

index d58c9a71d015693e41e46bcc756c8d5135a88dc0..40146a1381390704676beecb5415f83c2402de1d 100644

--- a/third_party/third_party.gyp

+++ b/third_party/third_party.gyp

@@ -239,6 +239,11 @@

}],

+ 'variables': {

+ 'clang_warning_flags': [

+ '-Wno-shift-negative-value',

Nico 2016/03/09 02:30:19 can you add a comment describing why this is neede

Oliver Chang 2016/03/09 17:00:17 Done.

+ ],

+ }

{

'target_name': 'fx_libopenjpeg',

@@ -322,7 +327,11 @@

}],

+ 'variables': {

+ 'clang_warning_flags': [

+ '-Wno-shift-negative-value',

Nico 2016/03/09 02:30:19 likewise

Oliver Chang 2016/03/09 17:00:17 Done.

+ ]

+ },

{

'target_name': 'pdfium_base',

« testing/gtest.gyp ('K') | « testing/gtest.gyp ('k') | no next file » | no next file with comments »