Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: testing/gtest.gyp

Issue 1774123005: Support clang-cl build on Windows. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/gtest.gyp
diff --git a/testing/gtest.gyp b/testing/gtest.gyp
index 3c01552c4c49a5478596bbb2266e45f1ce28f733..c1f58ba293e42f94f9f02ebff9bcd61f2fd3adba 100644
--- a/testing/gtest.gyp
+++ b/testing/gtest.gyp
@@ -142,6 +142,12 @@
],
'msvs_disabled_warnings': [4800],
},
+ 'variables': {
+ 'clang_warning_flags': [
+ '-Wno-reorder',
+ '-Wno-unused'
Nico 2016/03/09 02:30:19 We only need the first of these two in chromium's
Oliver Chang 2016/03/09 17:00:17 Added comments. We need both here for some reason
+ ],
+ },
},
{
'target_name': 'gtest_main',
« no previous file with comments | « build/standalone.gypi ('k') | third_party/third_party.gyp » ('j') | third_party/third_party.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698